Bug 137506

Summary: Move single control in "More Options" to print dialog
Product: LibreOffice Reporter: sdc.blanco
Component: UIAssignee: Ayhan Yalçınsoy <ayhanyalcinsoy>
Status: RESOLVED FIXED    
Severity: enhancement CC: heiko.tietze, mentoring
Priority: medium Keywords: difficultyBeginner, easyHack, skillCpp, topicUI
Version: 7.1.0.0.alpha0+   
Hardware: All   
OS: All   
Whiteboard: target:7.1.0
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 103309    
Attachments: Comparison of current and proposed layout for Print dialog

Description sdc.blanco 2020-10-15 14:04:07 UTC Comment hidden (obsolete)
Comment 1 sdc.blanco 2020-10-15 14:11:35 UTC
Created attachment 166388 [details]
Comparison of current and proposed layout for Print dialog

Question about dropping "More Options" button in Print dialog and moving its single option into the print dialog.

Attachment shows proposed design.  Three specific changes are proposed (and identified by number) in the attachment.

Reasons for changes:

1.  Control hidden in More Options is highly relevant to the Collate option and makes sense to have it located next to each other, rather than hidden in "More Options"

2.  Removes extra step in workflow.

3.  Seems like "overkill" to have "More Options" and only one control.
Comment 2 Heiko Tietze 2020-10-16 11:28:46 UTC
"Reverse order" is not depending on the number of copies as it would look like without the "Order" label. And not much benefit from removing it. 

No objection to separate jobs under collate although it makes the dialog even larger. The options button with one checkbox is in fact awkward.
Comment 3 Heiko Tietze 2020-10-22 13:19:29 UTC
We discussed the proposal in the design meeting. Moving the one option out of the More dialog makes sense, better as first option. But the label Order should remain and the Collate option also right of the number of copies.

Guess you volunteer to do it yourself, Seth. Otherwise I would add code pointer as this is likely an easy hack.
Comment 4 sdc.blanco 2020-10-22 13:40:49 UTC
(In reply to Heiko Tietze from comment #3)
> Otherwise I would add code pointer as this is likely an easy hack.
Please add code pointer as easy hack...
Comment 5 Heiko Tietze 2020-10-22 13:50:13 UTC
Code pointers:

./vcl/uiconfig/ui/printdialog.ui
./vcl/uiconfig/ui/moreoptionsdialog.ui

vcl/source/window/printdlg.cxx
Comment 6 Commit Notification 2020-10-29 08:22:57 UTC
Ayhan Yalçınsoy committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1628d815712ef40020f744a80b949e3cf4d8380d

tdf#137506: Move single control in 'More Options' to print dialog

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.