| Summary: | Wrong AdditionsTag crashes LibreOffice | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Heiko Tietze <heiko.tietze> |
| Component: | UI | Assignee: | Muhammet Kara <kara> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kara |
| Priority: | medium | ||
| Version: | 7.1.0.0.alpha0+ | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | target:7.1.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 133026 | ||
Confirmed on: Version: 7.1.0.0.alpha0+ Build ID: 49ba005c111b50c2d7b6c8c68d0a09d4eafa7288 CPU threads: 16; OS: Linux 5.8; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded It is not only specific to incorrect AdditionsTag, in fact. Caused by HTTP 404 Not Found error. Muhammet Kara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/3371e11d23635c69f242507a33b60daf2c21b433 tdf#137460: Additions: Fix crash on error 404 It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. If I read the code correctly it silently just doesn't work. The SAL_WARN() thing needs to show up somewhere in the UI. (In reply to Heiko Tietze from comment #3) > If I read the code correctly it silently just doesn't work. The SAL_WARN() > thing needs to show up somewhere in the UI. It works as intended. A wrong tag or url is not supposed to work anyway. This is not just silencing an issue, but fixes the crash reported. Regarding informing the user about what's going on, we already have another report for that: https://bugs.documentfoundation.org/show_bug.cgi?id=136291 (In reply to Muhammet Kara from comment #4) > It works as intended. A wrong tag or url is not supposed to work anyway. > This is not just silencing an issue, but fixes the crash reported. 404 is page not found, also happening when the server is down. Shouldn't happen, sure. |
css::uno::Sequence<css::beans::PropertyValue> aArgs(1); aArgs[0].Name = "AdditionsTag"; aArgs[0].Value <<= OUString("Foo"); <= this is wrong comphelper::dispatchCommand(".uno:AdditionsDialog", aArgs);