| Summary: | Custom widgets (e.g. list style preview dropdowns) should use themed colors and thicker width for hover highlight | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | medmedin2014 <med.medin.2014> |
| Component: | UI | Assignee: | Not Assigned <libreoffice-bugs> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | caolan.mcnamara, dgp-mail, heiko.tietze, m.weghorn, rafael.palma.lima, stephane.guillou |
| Priority: | medium | ||
| Version: | 7.0.1.2 release | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | target:24.8.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 108816 | ||
| Attachments: |
Mouse hover border line color is wrong
Item grid borders Color in grid lines |
||
I confirm it with Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community Build ID: f96004096268f5e71120678e32fc8c74055819aa CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL So we have a lot of different situations: Black borders (e.g. "Toggle Ordered List" and "Toggle Unordered List") Blue borders and blue highlight ("Page bordes" and "Set Line Spacing") Blue highlight without border ("Basic shapes") haven't tested all. Can't say, if there is a special idea behind or if it should all be the same => Design-Team Please define "wrong". My cursor is dark with a bright frame to be visible on all backgrounds. It never changes its color. (In reply to Heiko Tietze from comment #2) > Please define "wrong". My cursor is dark with a bright frame to be visible > on all backgrounds. It never changes its color. Not the mouse shape, what I mean is the black rectangle that is shown around the currently selected item in the grid and also the one around the item which the mouse pointer is hovering over. See attached image for more info. (In reply to medmedin2014 from comment #3) > what I mean is the black rectangle... And you expect it in blue, right? Created attachment 170979 [details]
Item grid borders
(In reply to Heiko Tietze from comment #4) > (In reply to medmedin2014 from comment #3) > > what I mean is the black rectangle... > > And you expect it in blue, right? Yes, the black borders are difficult to see on black background. Looking for code pointer in svx/tbxctrls/bulletsnumbering.cxx, svtools/uno/popupwindowcontroller.cxx, and vcl/window/dockwin.cxx|floatwin.cxx but no success. Caolan, do you have something on hand? The "Page Columns" dropdown contains real "buttons" while the bullets and numbering dropdown is a ValueSet which is implemented in svtools/source/control/valueset.cxx This one uses style WB_FLATVALUESET|WB_MENUSTYLEVALUESET so the highlight border is drawn at valueset.cxx:1278 where "mbBlackSel" is true so a black border is used. But why is mbBlackSel true, that's set to true with dubious(?) code (from initial import 8ab086b6cc054501bfbf7ef6fa509c393691e860) at line 1056 if the HighlightColor isn't considered satisfactory. So maybe the way to go is to remove mbBlackSel and just used the Highlight color and not second guess if its "good enough" mbBlackSel is false for me but even with forcing mbDoubleSel the line is so thin that I barely see it. Have to take a closer look, probably a sizing issue too. Thanks for the code pointer! Created attachment 183182 [details]
Color in grid lines
So it seems that the color is correct now. It is using the highlight color, but as pointed out by Heiko the line is so thin that I hadn't even noticed that it existed up until I read this bug report.
Tested with
Version: 7.3.6.2 / LibreOffice Community
Build ID: 30(Build:2)
CPU threads: 12; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Ubuntu package version: 1:7.3.6-0ubuntu0.22.04.2
Calc: threaded
Same as Rafael and Heiko, I see the correct highlight colour on Ubuntu 20.04 + GNOME 3.36.8, but the thickness makes it barely noticeable. Version: 7.5.0.2 (X86_64) / LibreOffice Community Build ID: c0dd1bc3f1a385d110b88e26ece634da94921f58 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: ec4babad021218b75dfe8534985d7db525edde69 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Heiko Tietze committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/abccf22947294cfc2d9c4b727b7fd059bed55f0b Resolves tdf#136917 - Focus rectangle barely visible on toolbar widgets It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Thanks Heiko, verified in: Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 505803e2cb4d60153be2218a17ede8e34d95b42e CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: CL threaded |
Created attachment 165716 [details] Mouse hover border line color is wrong When mouse hovers on item in bullet, numbered or style lists the item has a wrong border line color. See attached image for more info. Version: 7.0.1.2 Build ID: 00(Build:2) CPU threads: 2; OS: Linux 5.4; UI render: default; VCL: kf5 Locale: en-US (en_US.UTF-8); UI: en-US =7.0.1-1 Calc: threaded Operating System: Manjaro Linux KDE Plasma Version: 5.19.5 KDE Frameworks Version: 5.73.0 Qt Version: 5.15.0 Kernel Version: 5.4.64-1-MANJARO OS Type: 64-bit