Summary: | Background color doesn't work for all UNO controls (gtk3/kf5) | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Michael Weghorn <m.weghorn> |
Component: | graphics stack | Assignee: | Michael Weghorn <m.weghorn> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | bugzilla, m.weghorn |
Priority: | medium | ||
Version: | 7.1.0.0.alpha0+ | ||
Hardware: | All | ||
OS: | Linux (All) | ||
See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=136866 | ||
Whiteboard: | target:7.1.0 target:7.0.2 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 102495, 103182 | ||
Attachments: |
Sample doc containing dialog with form controls that have background color
Document with screenshot showing behaviour on different platforms/with different VCL plugins screenshot on macOS |
Description
Michael Weghorn
2020-08-25 05:56:58 UTC
Created attachment 164654 [details]
Sample doc containing dialog with form controls that have background color
Created attachment 164655 [details]
Document with screenshot showing behaviour on different platforms/with different VCL plugins
This PDF file contains screenshots for Windows and the different VCL plugins on Linux.
This bug was initially reported to me by a WollMux [1] developer, since they are working on replacing a Java Swing based form GUI by using the LibreOffice sidebar and LO controls, and background color is used e.g. to indicate invalid input/values in a form. WIP patch at https://gerrit.libreoffice.org/c/core/+/101284 [1] https://github.com/wollmux/wollmux Other than the background color for the controls, setting font colors etc. worked as expected in a quick test. Created attachment 164671 [details] screenshot on macOS This screenshot with master as of bf3124cdf61b40c94ba117a76f1b63dabdfd528e shows macOS, where more than just the background color is broken... I don't intend to look into this myself, just double-checked my patch in Gerrit does not affect the behavior there. Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/2c9052802ea411dffbf5906c4914611fcbfbc6a5 tdf#136094 Handle background color in drawNativeControl It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Patch from comment 6 fixes the gtk3 case; kf5 needs to be handled separately. the macOS code in drawNativeControl uses a truly ancient mac API that does not expose the ability to override such things, so that is no surprise. (In reply to Noel Grandin from comment #8) > the macOS code in drawNativeControl uses a truly ancient mac API that does > not expose the ability to override such things, so that is no surprise. if anybody wants to take a look at this, please feel free :) I plan to implement the qt5/kf5 part, but have ~zero macOS experience. Michael Weghorn committed a patch related to this issue. It has been pushed to "libreoffice-7-0": https://git.libreoffice.org/core/commit/e944b2d62b499f4d9392cf5ce067b905bc2d67ab tdf#136094 Handle background color in drawNativeControl It will be available in 7.0.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/391f17a5fbcf9cd918efa10321219f87409d2412 tdf#136094 qt5: Handle bg color in drawNativeControl It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Closing as fixed, since background color handling for gtk3 and kf5 has been implemented. There's still an issue with the multiline edit for the kf5 case; I've created a separate bug report for this: tdf#136866 *** Bug 128124 has been marked as a duplicate of this bug. *** |