Summary: | FILESAVE: DOCX with SmartArt roundtripped in Writer fails to open in Word | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Roman Kuznetsov <79045_79045> |
Component: | Writer | Assignee: | Justin L <jluth> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | aron.budea, grzegorz.araminowicz, jluth, vmiklos |
Priority: | medium | Keywords: | bibisected, bisected, filter:docx, regression |
Version: | 6.3.4.2 release | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=132368 https://bugs.documentfoundation.org/show_bug.cgi?id=125552 https://bugs.documentfoundation.org/show_bug.cgi?id=125551 |
||
Whiteboard: | target:7.3.0 target:7.2.5 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 104528, 106547 | ||
Attachments: | example DOCX |
Description
Roman Kuznetsov
2020-08-19 08:27:44 UTC
repro in 6.3 but not in 6.2 =>regression Created attachment 164445 [details]
example DOCX
Confirmed with LO 7.1.0.0.alpha0+ daily build from 08-15 / Windows. I bisected it and got bad commit aafaf1f55fa413ad49d4556cf7c0a713dd206ae4 https://gerrit.libreoffice.org/c/core/+/69598 CC: to Miklos Vajna and Grzegorz Araminowicz LO also complains about this document being wrong. The problem is in header1.xml. After the final </w:hdr> we have this extra stuff tacked on at the end. <wp:docPr id="2" name="Diagram2"/><wp:cNvGraphicFramePr/><a:graphic xmlns:a="http://schemas.openxmlformats.org/drawingml/2006/main"><a:graphicData uri="http://schemas.openxmlformats.org/drawingml/2006/diagram"><dgm:relIds xmlns:dgm="http://schemas.openxmlformats.org/drawingml/2006/diagram" xmlns:r="http://schemas.openxmlformats.org/officeDocument/2006/relationships" r:dm="rId2" r:lo="rId3" r:qs="rId4" r:cs="rId5"/></a:graphicData></a:graphic> oox's WriteDialog just writes to mpFS. writerfilter is not setting that FS before calling the function. so - sax_fastparser::FSHelperPtr pFS = m_pImpl->getSerializer(); should have been replaced by + m_pImpl->getDrawingML()->SetFS(m_pImpl->getSerializer()); Proposed fix at http://gerrit.libreoffice.org/c/core/+/125441 Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/0afd2d3bfa9d55249ffd1408681ff04decf2d8fa tdf#135906 docxexport: set serializer before writing It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Justin Luth committed a patch related to this issue. It has been pushed to "libreoffice-7-2": https://git.libreoffice.org/core/commit/5853e4d137c3cb535571cba0233b05a48761ac52 tdf#135906 docxexport: set serializer before writing It will be available in 7.2.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. 7.2.4 was a hotfix release, updating target in status-whiteboard |