Bug 130456

Summary:	Should the "Transparency" control be visible in the "Font Effects" tab for Paragraph Style and Character Style in Writer?
Product:	LibreOffice	Reporter:	sdc.blanco
Component:	Writer	Assignee:	Miklos Vajna <vmiklos>
Status:	VERIFIED FIXED
Severity:	enhancement	CC:	aron.budea, dgp-mail, heiko.tietze, vmiklos
Priority:	medium
Version:	6.3.4.2 release
Hardware:	All
OS:	All
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=130384
Whiteboard:	target:7.0.0
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	107833, 108014

Description sdc.blanco 2020-02-05 12:47:10 UTC

There is no transparency control in the "font effects" tab for Writer Paragraph Style and Character Style dialogs.

In Writer, Format>Character-Font Effects tab has a transparency control.

For the other modules (Calc, Draw, Impress), all "font effects" tab (also for styles) have a transparency control.

Bug or not?

Comment 1 Miklos Vajna 2020-02-18 08:06:09 UTC

I believe https://gerrit.libreoffice.org/plugins/gitiles/core/+diff/6d6e80435fd7f71342c429a67759a7b7b280cc55%5E%21 does what you ask for, does it?

Comment 2 Miklos Vajna 2020-02-18 11:19:48 UTC

Ah, confirmed, direct formatting has it, the Style versions don't. Could be added, indeed.

Comment 3 Heiko Tietze 2020-02-19 12:40:18 UTC

Cool stuff. But please follow the guidelines for property dialogs https://wiki.documentfoundation.org/Design/Guidelines/PropertyDialog (labels are left-aligned -> https://gerrit.libreoffice.org/c/core/+/89017). 

No need for input from UX, character dialog is done, paragraph style missing.

Comment 4 sdc.blanco 2020-02-20 22:50:04 UTC

(In reply to Miklos Vajna from comment #2)
> Ah, confirmed, direct formatting has it, the Style versions don't. Could be
> added, indeed.
@Miklos - I was going to try, but I cannot figure out why it is not already being shown.  

- assume Paragraph Style and Character Style also use effectpage.ui
- which is controlled with cui/source/tabpages/chardlg.cxx  
- where the relevant place to hide the transparency controls is: 

2450  if ((nFlags & SVX_ENABLE_CHAR_TRANSPARENCY) != SVX_ENABLE_CHAR_TRANSPARENCY)

- assume problem is that "Paragraph Style" and "Character Style" are not passing the needed flag 

- but cannot see where the flags for Paragraph and Character Style are defined. 
Do you happen to have information about that?

Comment 5 Miklos Vajna 2020-02-21 08:51:34 UTC

Not off the top of my head; the usual approach is to put a breakpoint to the place where the chardlg is created (perhaps the SvxCharEffectsPage ctor) and then see the backtrace in the debugger. I hope that will give you the place where you indeed probably just need to opt in by specifying SVX_ENABLE_CHAR_TRANSPARENCY.

Comment 6 Commit Notification 2020-05-26 08:21:28 UTC

Miklos Vajna committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/5202771939da66ac85ca3221d69e7e5f5cca8da7

tdf#130456 sw: enable semi-transparent text for char style dialog

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Comment 7 Dieter 2020-06-04 11:48:26 UTC

Verified with

Version: 7.0.0.0.beta1 (x64)
Build ID: 94f789cbb33335b4a511c319542c7bdc31ff3b3c
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL

Miklos, thanks for fixing it!