Bug 129944

Summary: Embedded diagram from .DOC/.DOCX opens read-only
Product: LibreOffice Reporter: Aron Budea <aron.budea>
Component: WriterAssignee: Not Assigned <libreoffice-bugs>
Status: NEW ---    
Severity: normal Keywords: bibisected, bisected, regression
Priority: medium    
Version: 6.2.2.2 release   
Hardware: All   
OS: All   
See Also: https://bugs.documentfoundation.org/show_bug.cgi?id=119530
https://bugs.documentfoundation.org/show_bug.cgi?id=110987
Whiteboard:
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 107810    

Description Aron Budea 2020-01-11 16:50:51 UTC
Timur's steps from bug 119530:

"Open DOC attachment 52631 [details] from Bug 42112 or .DOCX attachment 144474 [details] from Bug 119529. 
Double click diagram to open embedded document. 
Could be open and edited with 6.1, but opens read-only in 6.2+ so we cannot edit it.

Not sure if regression or on purpose because editing is wrong. 

Note: if one has MSO, depending on settings, double click can open MSO but it should open LO, as can be seen where there's no MSO."

This was first caused as a side-effect of the following commit:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=c1817a5b12da642e365a3ef72b556d33c6e29a76
author		Aron Budea <aron.budea@collabora.com>	2017-08-02 03:34:24 +0200
committer	Jan Holesovsky <kendy@collabora.com>	2018-07-13 18:25:27 +0200

tdf#110987: type detection, binary Office formats > templates


Got fixed by this revert:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=1bb732acc6b4d3de94f343041472ccc096723b30
author		Aron Budea <aron.budea@collabora.com>	2018-09-08 14:27:41 +0200
committer	Aron Budea <aron.budea@collabora.com>	2018-09-08 20:11:10 +0200

Revert "tdf#110987: type detection, binary Office formats > templates"


And reintrocued by the following:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=65559252f138aada7a55d3c5fe0a932a222d13e0
author		Tor Lillqvist <tml@collabora.com>	2019-02-19 11:03:20 +0200
committer	Tor Lillqvist <tml@collabora.com>	2019-02-19 18:02:30 +0100

tdf#110987: Don't mis-detect .doc files as .dot