Summary: | Show MIME type icon in main menu File>Recent documents list | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Rizal Muttaqin <rizmut> |
Component: | UI | Assignee: | Bayram Çiçek <bayram.cicek> |
Status: | VERIFIED FIXED | ||
Severity: | normal | CC: | 79045_79045, heiko.tietze, lo, mentoring, momonasmon, vsfoote |
Priority: | medium | Keywords: | difficultyInteresting, easyHack, skillCpp, topicUI |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | target:7.2.0 | ||
Crash report or crash signature: | Regression By: | ||
Attachments: |
macOS 11.2.3, LibreOffice nightly 2021-04-07
MIME type in recent document list a MIME type of protected file in Start Center |
Description
Rizal Muttaqin
2019-12-03 04:40:10 UTC
Rizal, do you mean recent files list in the main menu? (In reply to Roman Kuznetsov from comment #1) > Rizal, do you mean recent files list in the main menu? Yes, absolutely you are right Yes. It makes sense where icons in menus are enabled, at least. +1, but only when showing icons in menus is enabled. (In reply to V Stuart Foote from comment #4) > +1, but only when showing icons in menus is enabled. Yes, this enhancement request will not affects user with GTK3 backend and also the option has been removed :) (see tdf#123265) Code pointer for the files list is framework/source/uielement/recentfilesmenucontroller.cxx with the fillPopupMenu() method. Somewhat tricky might be to do something similar as in sfx2/source/control/recentdocsview.cxx getDefaultThumbnail(). I would like to work on this. Assigning to myself. (In reply to Bayram Çiçek from comment #7) > I would like to work on this. Assigning to myself. Nice, I hope "Clear recent documents list" get an icon also. ;) (In reply to Rizal Muttaqin from comment #8) > Nice, I hope "Clear recent documents list" get an icon also. ;) Hi. I've implemented displaying icons in 'File->Recent Documents' list. However, I couldn't find the code pointer(s) for "Clear recent documents list". Could you please specify the code pointers?. Thanks. (In reply to Bayram Çiçek from comment #9) > (In reply to Rizal Muttaqin from comment #8) > > > Nice, I hope "Clear recent documents list" get an icon also. ;) > Hi. I've implemented displaying icons in 'File->Recent Documents' list. > However, I couldn't find the code pointer(s) for "Clear recent documents > list". Could you please specify the code pointers?. > > Thanks. I have zero understanding in code, hope Maxim could help Bayram Çiçek committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/6fcabbd6199869753fd6a266f23901962a77f556 tdf#129153: Show MIME type icon in main menu File>Recent documents list It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Created attachment 170992 [details]
macOS 11.2.3, LibreOffice nightly 2021-04-07
verified - thanks this is a welcome change and addition to LibreOffice.
Created attachment 171089 [details]
MIME type in recent document list
Unfortunately a protected document has a regular icon instead of a file with a padlock (or similar). Here's "Presentasi Terproteksi.odp" as an example.
I am not sure whether this request is still covered by this report or not.
Created attachment 171090 [details] a MIME type of protected file in Start Center (In reply to Rizal Muttaqin from comment #13) > Created attachment 171089 [details] > MIME type in recent document list > > Unfortunately a protected document has a regular icon instead of a file with > a padlock (or similar). Here's "Presentasi Terproteksi.odp" as an example. > > I am not sure whether this request is still covered by this report or not. While in Start Center, I get this kind of MIME type (In reply to Rizal Muttaqin from comment #13) > I am not sure whether this request is still covered by this report or not. Menu icons never showed encryption. And I doubt it works well with 16px. |