Summary: | Editing a particular math formula using underbrace / overbrace destroys the UI under GTK3 | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Jean-Baptiste Faure <jbfaure> |
Component: | Formula Editor | Assignee: | Caolán McNamara <caolan.mcnamara> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | caolan.mcnamara, jumbo4444, xiscofauli |
Priority: | medium | Keywords: | bibisected, bisected |
Version: | 6.0.7.3 release | ||
Hardware: | x86-64 (AMD64) | ||
OS: | Linux (All) | ||
See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=132112 | ||
Whiteboard: | target:6.4.0 target:6.3.2 target:6.2.8 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 39750, 103182 | ||
Attachments: |
test file (math formula)
test file with embedded formula from real life pdf export screencopy with gtk3 plugin (view) screencopy with gtk3 plugin (editing) screencopy with gen plugin |
Description
Jean-Baptiste Faure
2019-08-27 19:54:41 UTC
Created attachment 153688 [details]
test file (math formula)
Created attachment 153689 [details]
test file with embedded formula from real life
Created attachment 153690 [details]
pdf export
Created attachment 153691 [details]
screencopy with gtk3 plugin (view)
Created attachment 153692 [details]
screencopy with gtk3 plugin (editing)
Created attachment 153693 [details]
screencopy with gen plugin
set as regression because it worked with earlier version. That said I do not know if the problem is in LibreOffice or in libfreetype. Set importance as high/major because user may believe that her document is corrupted and her data are lost. Best regards. JBF I can reproduce with Version: 6.3.0.4 Build ID: 057fc023c990d676a43019934386b85b21a9ee99 Threads CPU : 8; OS : Linux 4.15; UI Render : par défaut; VCL: gtk3; Locale : fr-FR (fr_FR.UTF-8); Langue IHM : fr-FR Calc: threaded I do NOT reproduce with: - Version: 6.0.7.2 Build ID: 78c12ce5f2b8960f18b204a7ea82f971769f1679 Threads CPU : 8; OS : Linux 4.15; UI Render : par défaut; VCL: gtk2; Locale : fr-FR (fr_FR.UTF-8); Calc: group - Version: 6.1.6.3 Build ID: 5896ab1714085361c45cf540f76f60673dd96a72 Threads CPU : 8; OS : Linux 4.15; UI Render : par défaut; VCL: gtk2; Locale : fr-FR (fr_FR.UTF-8); Calc: group threaded I DO reproduce with: - Version: 6.2.6.2 Build ID: 684e730861356e74889dfe6dbddd3562aae2e6ad Threads CPU : 8; OS : Linux 4.15; UI Render : par défaut; VCL: gtk3; Locale : fr-FR (fr_FR.UTF-8); Langue IHM : fr-FR Calc: threaded (In reply to Laurent BP from comment #9) > I do NOT reproduce with: > - Version: 6.0.7.2 > Build ID: 78c12ce5f2b8960f18b204a7ea82f971769f1679 > Threads CPU : 8; OS : Linux 4.15; UI Render : par défaut; VCL: gtk2; > Locale : fr-FR (fr_FR.UTF-8); Calc: group > - Version: 6.1.6.3 > Build ID: 5896ab1714085361c45cf540f76f60673dd96a72 > Threads CPU : 8; OS : Linux 4.15; UI Render : par défaut; VCL: gtk2; > Locale : fr-FR (fr_FR.UTF-8); Calc: group threaded > > I DO reproduce with: > - Version: 6.2.6.2 > Build ID: 684e730861356e74889dfe6dbddd3562aae2e6ad > Threads CPU : 8; OS : Linux 4.15; UI Render : par défaut; VCL: gtk3; > Locale : fr-FR (fr_FR.UTF-8); Langue IHM : fr-FR > Calc: threaded Do you see the big underbrace with gtk2 ? Best regards. JBF There is no large underbrace with "ce qui entre", with any version, with any VCL I tested. Even with old Version: 5.2.7.2 Build ID: 2b7f1e640c46ceb28adf43ee075a6e8b8439ed10 Threads CPU : 8; Version de l'OS :Linux 4.15; UI Render : par défaut; VCL : x11; Locale : fr-FR (fr_FR.UTF-8); Calc: group I saw it in small preview, preview printing and PDF export. Equation is visible (except the big underbrace "ce qui entre") also with LibreOffice 3.3.0 OOO330m19 (Build:6) tag libreoffice-3.3.0.4 (In reply to Laurent BP from comment #12) > Equation is visible (except the big underbrace "ce qui entre") also with > LibreOffice 3.3.0 > OOO330m19 (Build:6) > tag libreoffice-3.3.0.4 Same behavior as LibO 3.3.0 for AOO 4.1.3 Installing Freetype 2.9.1 from Ubuntu PPA "Better font rendering" solves the problem for me. So it seems that the bug is in Freetype, not in LibreOffice. That said I wonder if it is possible for LibreOffice to protect itself against this external bug ? Best regards. JBF Same problem with overbrace. Best regards. JBF Using GTK3, the UI is broken until https://cgit.freedesktop.org/libreoffice/core/commit/?id=302af8c2da58719844d22483b65a9fe5b3674684, after this commit, the UI is fine but the formula is no longer displayed. I don't think this is a regression... @Caolán, I thought you might be interested in this issue... (In reply to Xisco Faulí from comment #16) > Using GTK3, the UI is broken until > https://cgit.freedesktop.org/libreoffice/core/commit/ > ?id=302af8c2da58719844d22483b65a9fe5b3674684, after this commit, the UI is > fine but the formula is no longer displayed. I don't think this is a > regression... > > @Caolán, I thought you might be interested in this issue... Hi Xisco, Which version of Freetype was installed on your computer when you did your tests? Best regards. JBF I can see this in a VM with Ubuntu 18.04. The render of, I presume the stretched glyph, fails in cairo_show_glyphs and set a cairo_status of @CAIRO_STATUS_FREETYPE_ERROR. Once a cairo context error state is set then it stops drawing and cannot be reset. The freetype commit which fixed this is https://git.savannah.gnu.org/cgit/freetype/freetype2.git/commit/?id=91015cb41d8f56777f93394f5a60914bc0c0f330 I think I can avoid rendering the case that then goes on to ruin subsequent drawing. The brace itself will still disappear when it gets stretched to that breaking point with freetype <= 2.8 but the rest of the drawing will be unaffected. Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/df4a6f977843dbf4eb8bb5998b090d92c454611b%5E%21 tdf#127189 FreeType <= 2.8 will fail to render stretched horizontal brace... It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. fixed in master, backport to 6-3 in gerrit. Note the brace itself will still fail to appear at a certain stretch after this fix with freetype 2.8, but the rest of rendering is supposed to not then fail Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-6-3": https://git.libreoffice.org/core/+/aab09918d349c251e0741263bfe252488690dd97%5E%21 tdf#127189 FreeType <= 2.8 will fail to render stretched horizontal brace... It will be available in 6.3.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-6-2": https://git.libreoffice.org/core/+/948d77ec605d9d31047a8e5e34a51303d9cff815%5E%21 tdf#127189 FreeType <= 2.8 will fail to render stretched horizontal brace... It will be available in 6.2.8. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |