Summary: | Character style borders appear on formatting changes, and not only when next style is encountered | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | leo.dalecki |
Component: | Writer | Assignee: | Not Assigned <libreoffice-bugs> |
Status: | VERIFIED FIXED | ||
Severity: | normal | CC: | dgp-mail, himajin100000, jluth, marklh9, santi.biliflasca, xiscofauli |
Priority: | medium | Keywords: | bibisected, bisected, needUITest, regression |
Version: | 5.3.0.3 release | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=87224 | ||
Whiteboard: | target:6.4.0 target:6.3.5 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 108014 | ||
Attachments: |
Screenshot showing the behavior of character style borders in LibreOffice 5.2 (borders are in red).
Screenshot showing the behavior of character style borders in LibreOffice 6 (borders are in red). |
Description
leo.dalecki
2019-07-11 19:58:31 UTC
Created attachment 152729 [details]
Screenshot showing the behavior of character style borders in LibreOffice 5.2 (borders are in red).
Created attachment 152730 [details]
Screenshot showing the behavior of character style borders in LibreOffice 6 (borders are in red).
I confirm this behaviour with Version: 6.2.5.2 (x64) Build-ID: 1ec314fa52f458adc18c4f025c545a4e8b22c159 CPU-Threads: 4; BS: Windows 10.0; UI-Render: GL; VCL: win; Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE Calc: threaded Steps to reproduce in LO 6.2.5.2 1. Create a character style with borders on both side 2. Apply the style to some text; 3. Underline one of the words in the styled text; Result: New borders are added I also could reproduce this with Version: 5.4.7.2 (x64) Build-ID: c838ef25c16710f8838b1faec480ebba495259d0 CPU-Threads: 4; BS: Windows 6.19; UI-Render: GL; Gebietsschema: de-DE (de_DE); Calc: group *** Bug 116361 has been marked as a duplicate of this bug. *** (In reply to Justin L from comment #4) > *** Bug 116361 has been marked as a duplicate of this bug. *** The duplicate bug report supplies test document attachment 140697 [details] It also shows that this began in LO 5.3 with http://cgit.freedesktop.org/libreoffice/core/commit/?id=d5fab973d0af95c433c5f6a9492014f7db642489 Note that pretty much any character property will add A SINGLE borderline at the first instance of a character run change. I reproduced with bold, italic, fontsize, fontcolor etc. It seems to be a visual thing only, because round-tripping the file doesn't look bad in the pre-bug version. The key to reproducing this bug is that the border needs to start at the beginning of the paragraph. It doesn't depend on using a style or shortcuts or anything like that. proposed fix at https://gerrit.libreoffice.org/76983 tdf#126353, but it really needs to be checked by Mark to make sure that doesn't break his intentions. Mark Hung committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/56e95f8e20b20680d025f3ecbeb4cc5306085b1e%5E%21 tdf#126353 merge character borders on layout portions. It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. A polite ping to Mark Hung: Is this bug fixed? if so, could you please close it as RESOLVED FIXED ? Otherwise, Could you please explain what's missing? Thanks Verified with Version: 6.5.0.0.alpha0+ (x64) Build ID: e26d89371f0e4f41476c9a99be01d98dedb76776 CPU threads: 4; OS: Windows 10.0 Build 18362; UI render: default; VCL: win; Locale: de-DE (de_DE); UI-Language: en-GB Calc: threaded Mark, thanks for fixing it! Mark Hung committed a patch related to this issue. It has been pushed to "libreoffice-6-3": https://git.libreoffice.org/core/commit/1e811754d230dd59ec54d0653284ca4737edb8b9 tdf#126353 merge character borders on layout portions. It will be available in 6.3.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |