Summary: | Calc does not import xlsx from Excel 2.4 correctly - Chart axis title rotated (OK if resaved in MSO) | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Johann Spies <johann.spies> |
Component: | Chart | Assignee: | Tünde Tóth <tundeth> |
Status: | VERIFIED FIXED | ||
Severity: | normal | CC: | johann.spies, markus.mohrhard, raal, varga.balazs3, xiscofauli |
Priority: | medium | Keywords: | bibisected, bisected, filter:xlsx, regression |
Version: | 5.0.0.5 release | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=75316 https://bugs.documentfoundation.org/show_bug.cgi?id=130671 https://bugs.documentfoundation.org/show_bug.cgi?id=137734 |
||
Whiteboard: | target:7.1.0 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 75057 | ||
Attachments: |
The xlsx-file wrongly imported.
The xlsx-file compared MSO 2016 LO 6.4+.png The example file saved by Excel 365 The original file and its Excel-saved version side by side in LO 7.0alpha |
Description
Johann Spies
2019-06-27 13:22:06 UTC
Created attachment 152445 [details]
The xlsx-file wrongly imported.
I can confirm with Version: 6.4.0.0.alpha0+ Build ID: 9fbedb7929936a45967ae49bc15b985f95e2ebd3 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; but not in Version 4.1.0.0.alpha0+ (Build ID: efca6f15609322f62a35619619a6d5fe5c9bd5a) Created attachment 152593 [details]
The xlsx-file compared MSO 2016 LO 6.4+.png
"File not imported correctly" is always a wrong title.
Bugzilla is not "document based", like "this document doesn't display nice".
Bugzilla is "issue based", so a single issue must be pointed at, after a search for not being a duplicate.
We need to precise what is a single issue here.
FWIS and what needs to be checked in the existing bugs:
- chart title is missing (from before)
- axis title rotated (change in 5.0 but for both)
- values are missing (regression from 5.0)
Regression introduced by: author Markus Mohrhard <markus.mohrhard@googlemail.com> 2015-05-06 06:08:47 +0200 committer Markus Mohrhard <markus.mohrhard@googlemail.com> 2015-05-08 14:56:41 +0200 commit 07e3155a666e85b8213608423ae84dbd2b30c3dc (patch) tree 560bf3f1389f16721f71de406827c5ff975cb32d parent 8a051cb9543b49cc70f5e6728df3387b128d3daf (diff) inherit default title rotation from parent, tdf#75316 Bisected with: bibisect-50max Adding Cc: to Markus Mohrhard @Balazs Varga, I thought you could be interested in this issue... Xisco, which of these is now this bug, per your bibisect, 2. or 3.? 1. chart title is missing (from 4.4). I converted bug 119138 to this issue. 2. axis title rotated (change in 5.0 but for both) 3. values are missing (regression from 5.0) (In reply to Timur from comment #6) > Xisco, which of these is now this bug, per your bibisect, 2. or 3.? > > 1. chart title is missing (from 4.4). I converted bug 119138 to this issue. > 2. axis title rotated (change in 5.0 but for both) > 3. values are missing (regression from 5.0) Hi Timur, the bisection is about the number 2, the axis titles being rotated... @Balasz, I thought you might be interested in this issue... This happens because for the <catAx> tag there is value: <axPos val="l"/> set. Which is wrong (left), it should be: <c:axPos val="b"/> (below) Excel imports this value and corrects it after saving to a different file. Created attachment 157764 [details]
The example file saved by Excel 365
Created attachment 157766 [details]
The original file and its Excel-saved version side by side in LO 7.0alpha
After saving the file with Excel, the output is shown correctly in Calc.
Tünde Tóth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e64f9356df76c41e3c5c432984e11110ce1d25ca tdf#126133 Chart OOXML import: set default text rotation to 0° It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Verified in Version: 7.1.0.0.alpha1+ Build ID: 9c8ed8c8526b9b696d0bf592eb7d963950f3cef4 CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: x11 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded @Tünde Tóth, thanks for fixing this issue! I tried to backport it but the unittest depends on another unittest. I guess we can live without the backport for a few months. In the end, this is a regression from 5.0 |