Bug 125282

Summary:	UX: The Find bar should search in “Current selection only” if a cell range is selected
Product:	LibreOffice	Reporter:	Gabor Kelemen (allotropia) <kelemeng>
Component:	Calc	Assignee:	Not Assigned <libreoffice-bugs>
Status:	RESOLVED WORKSFORME
Severity:	normal	CC:	79045_79045, heiko.tietze, libreoffice, thomas.lendo
Priority:	medium
Version:	6.3.0.0.alpha0+
Hardware:	All
OS:	All
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=129781
Whiteboard:
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	108019, 108743
Attachments:	Searching in the selected range only with Find & Replace Searching with the Find bar finds results in the whole sheet

Description Gabor Kelemen (allotropia) 2019-05-14 11:51:37 UTC

Created attachment 151402 [details]
Searching in the selected range only with Find & Replace

In Calc searching happens in the selected range if there are non-empty cells selected, as the “Current selection only” option of the Find & Replace window is then turned on by default. This is good.

In the Find bar however even if there is a cell range with non empty cells selected the search happens in the whole sheet.

I think it would be a sane default to assume that users who selected a range and start searching with the Find bar want to limit the search to the range, just like we assume it in case of the Find & Replace window.

Steps to reproduce:
1.	In Calc type some text in a few cells
2.	Select a cell range with some, but not all of the cells
3.	Press Ctrl-H and search for the word just typed
4.	Calc searches only in the selected range
5.	Press Ctrl-F and try to search for the same string with the Find bar.
6.      Notice that it finds results outside the selected range as well.

Actual results:
Searching with the Find bar happens on the whole sheet.

Expected results:
Searching with the Find bar should happen only inside the selected cell range if there is one.

LibreOffice details:

Version: 6.3.0.0.alpha0+
Build ID: c5c425296debb2fbd67af8ec29f87e285d08575f
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
Locale: hu-HU (hu_HU); UI-Language: en-US
Calc: threaded

Comment 1 Gabor Kelemen (allotropia) 2019-05-14 11:52:18 UTC

Created attachment 151403 [details]
Searching with the Find bar finds results in the whole sheet

Comment 2 Roman Kuznetsov 2019-05-14 12:22:25 UTC

hm, I confirm in

Version: 6.3.0.0.alpha0+
Build ID: 773ac3abbf8ab1343367e51b1774d2ee1f8c4f49
CPU threads: 4; OS: Windows 6.1; UI render: default; VCL: win; 
Locale: ru-RU (ru_RU); UI-Language: en-US
Calc: threaded

but I don't like as it's now

better to make checkbox "Find only in selection" in F&R dialog and in Find tollbar too

Now if I want change selection for finding without closing the F&R dialog, then next finding will be for all cells on sheet regardless of the current selection.

May be need fill an another enhancement about it

Comment 3 Heiko Tietze 2019-05-16 12:08:28 UTC

I disagree here. The find bar is overloaded options right now and adding another option makes this UI control even more heavy. In my opinion it's just two different ways to search with a more straightforward option for the find bar that just has "Find All". And I'm definitely against assuming the user wants always to search in the current selection. 

More opinions please.

Comment 4 Heiko Tietze 2019-05-23 12:38:08 UTC

No more input so taking my opinion here and resolve as wfm. The workflows are just different between the find toolbar and the dialog.

Comment 5 Thomas Lendo 2019-05-28 18:49:57 UTC

To document my opinion although the bug is closed:

I'm in favor of synchronizing the behavior of both the find bar and the find dialog. But there should be no new option in the find bar. As Heiko said, the find bar is already overloaded.

Reason for my opinion: The finding feature should act identical regardless of which of both ways the user is using.