Bug 124263

Summary:	Sidebar extensions with large getMinimalWidth cause issues
Product:	LibreOffice	Reporter:	Samuel Mehrbrodt (allotropia) <samuel.mehrbrodt>
Component:	UI	Assignee:	Samuel Mehrbrodt (allotropia) <samuel.mehrbrodt>
Status:	RESOLVED FIXED
Severity:	normal	CC:	samuel.mehrbrodt, xiscofauli
Priority:	medium
Version:	Inherited From OOo
Hardware:	All
OS:	All
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=124255 https://bugs.documentfoundation.org/show_bug.cgi?id=124654 https://bugs.documentfoundation.org/show_bug.cgi?id=141294
Whiteboard:	target:6.3.0
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	103459

Description Samuel Mehrbrodt (allotropia) 2019-03-22 10:07:48 UTC

Sidebar extensions can define their minimum width via XSidebarPanel::getMinimalWidth.

However, if this size is larger than the maximum size of the sidebar, this causes issues (resizing is broken, causes "jumping", etc.)
Basically the behavior is undefined.

This should be fixed, probably by increasing the maximum allowed width of the sidebar if this value is larger than the current max width.

Comment 1 Commit Notification 2019-03-22 13:45:01 UTC

Samuel Mehrbrodt committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/d0c73ce13c02c37fcc094ac6612d6a8eee2a4026%5E%21

tdf#124263 Respect XSidebarPanel::getMinimalWidth

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Comment 2 Commit Notification 2019-03-25 15:20:20 UTC

Samuel Mehrbrodt committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/a58391b1f61db702a5246c5a33717cbba68c5252%5E%21

Related tdf#124263 Make sure sidebar is wide enough for content

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.