Summary: | After save a DOCX file, it gives a error when it try to be open (avoid duplicate themeColor) | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Angel <angelb> |
Component: | Writer | Assignee: | Julien Nabet <serval2412> |
Status: | VERIFIED FIXED | ||
Severity: | critical | CC: | dgp-mail, frederic.parrenin, kelemeng, mikekaganski, serval2412, telesto |
Priority: | medium | Keywords: | haveBacktrace |
Version: | 5.0.0.5 release | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=113790 | ||
Whiteboard: | target:6.3.0 target:6.2.2 target:6.1.6 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 104450 | ||
Attachments: |
Test file for bug
bt with debug symbols |
Description
Angel
2019-02-25 15:13:18 UTC
Created attachment 149580 [details]
Test file for bug
I confirm it with Version: 6.3.0.0.alpha0+ (x64) Build ID: f42554a1886ebe49170c25096dc3281b2c7bb1f4 CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; TinderBox: Win-x86_64@42, Branch:master, Time: 2019-02-08_22:37:30 Locale: en-US (de_DE); UI-Language: en-US Calc: threaded Created attachment 149585 [details]
bt with debug symbols
On pc Debian x86-64 with master sources updated some days ago + enable-dbgutil, I got an assert after having changed a bit the file and saved it.
Considering https://opengrok.libreoffice.org/xref/core/sw/source/filter/ww8/docxattributeoutput.cxx?r=167d4a99#2458 which clears: - m_pFontsAttrList - m_pEastAsianLayoutAttrList - m_pCharLangAttrList but also m_pColorAttrList I wonder we shouldn't add in sw/source/filter/ww8/docxattributeoutput.cxx#2930 these lines: rtl::Reference<sax_fastparser::FastAttributeList> pColorAttrList_Original(m_pColorAttrList); m_pColorAttrList.clear(); then: m_pColorAttrList = pColorAttrList_Original; I'll test this tonight. Patch on review for master branch: https://gerrit.libreoffice.org/#/c/68398/ Julien Nabet committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/42398e3860aafd6468688eda6c0da942323b7f82%5E%21 tdf#123705: avoid duplicate themeColor It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. backports waiting for review: - 6.2: https://gerrit.libreoffice.org/#/c/68613/ - 6.1: https://gerrit.libreoffice.org/#/c/68614/ Julien Nabet committed a patch related to this issue. It has been pushed to "libreoffice-6-2": https://git.libreoffice.org/core/+/7b9e13376423d54cf95dfc48c9d3de0a62826943%5E%21 tdf#123705: avoid duplicate themeColor It will be available in 6.2.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. *** Bug 118237 has been marked as a duplicate of this bug. *** Julien Nabet committed a patch related to this issue. It has been pushed to "libreoffice-6-1": https://git.libreoffice.org/core/+/a1e44657ef62488076b0f4cfd271d0a73cbff7d3%5E%21 tdf#123705: avoid duplicate themeColor It will be available in 6.1.6. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Repro with LO 5.0, maybe also with 4.4. *** Bug 125136 has been marked as a duplicate of this bug. *** |