Summary: | selection from Firefox themes (own theme) no longer works ( Firefox changed the API & removed the footer images) | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Max Merbald <max.merbald> |
Component: | LibreOffice | Assignee: | Not Assigned <libreoffice-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | 22shubh22, aron.budea, ashutoshkukreti1212, davidarchives24, erbenton, fachkraftengine, fieldman, franklin, jbfaure, kara, michael.meeks, pierre.tissendier, sanipachenko, tim.chambers1968, xiscofauli, zyzilikin |
Priority: | medium | ||
Version: | 6.2.0.3 release | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=118881 | ||
Whiteboard: | target:6.3.0 target:6.2.4 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 86544 |
Description
Max Merbald
2019-02-07 15:41:48 UTC
Muhammet: thought you might be interested in this one. Yes, Firefox changed the API ( again ), so it doesn't work anymore... *** Bug 123240 has been marked as a duplicate of this bug. *** *** Bug 123249 has been marked as a duplicate of this bug. *** Michael: considering that we may quickly have several dups of this one, thought it could be interesting to put Persona/themes management again on ESC. (last time was http://document-foundation-mail-archive.969070.n3.nabble.com/minutes-of-conference-ESC-call-td4249713.html). Should we finally deprecate this feature and put it as an extension? I second Julien's suggestion. Better to ship "Themes" as an extension, and perhaps include a larger variety of pre-installed themes like "solid grey" (I really like that one!) Sounds sensible wrt. ESC - sure, will try to remember to add it - Muhammet may have some ideas about how to do this. I agree that downloading them is far from ideal, and shipping them pre-canned and/or as extensions and controlling the packaging thereof is likely to be a far better idea. It would be nice not to depend on Mozilla there. Would this still enable me to chose a theme from firefox? Or any own one? In january I try in a Beta2 and works. Something happens. (In reply to Michael Meeks from comment #7) > Sounds sensible wrt. ESC - sure, will try to remember to add it - Muhammet > may have some ideas about how to do this. I agree that downloading them is > far from ideal, and shipping them pre-canned and/or as extensions and > controlling the packaging thereof is likely to be a far better idea. It > would be nice not to depend on Mozilla there. Depending on MOZ API for themes proved itself to be unreliable. I would vote for deprecating the search feature (or turning it to an experimental feature) in 6.3. Some ideas might be: * Theme packs via extensions * A gallery for local/installed-via-extension themes @Muhamett would extension-themes be experimental in 6.3 too? Or stable? I also find that you can no longer use your own Personas already installed and used in your gallery/personas user folder using 6.2.0.3. I am unable to restore the personas using expert configuration or modifying the .xcu file directly. Perhaps my update is no longer correct. For example for the .xcu file <item oor:path="/org.openoffice.Office.Common/Misc"><prop oor:name="Persona" oor:op="fuse"><value>own</value></prop></item> <item oor:path="/org.openoffice.Office.Common/Misc"><prop oor:name="PersonaSettings" oor:op="fuse"><value>default-personas;Default-Personas;default-personas/preview.jpg;default-personas/default-header.jpg;default-personas/default-footer.jpg;#0000ff;#000000</value></prop></item> and for the OWN personalization option using expert configuration default-personas;Default-Personas;default-personas/preview.jpg;default-personas/default-header.jpg;default-personas/default-footer.jpg;#0000ff;#000000 Any advice?? The personas_list.txt appears to have inconsistent line entries. For example the default on in 6.2 on my system is. white;White;white/preview.png;white/header.png;white/footer.png;;#000000;#ffffff gray;Gray;gray/preview.png;gray/header.png;gray/footer.png;;#000000;#ffffff dark;Dark;dark/preview.png;dark/header.png;dark/footer.png;#ffffff;#000000 pink;Pink;pink/preview.png;pink/header.png;pink/footer.png;;#000000;#ffffff sand;Sand;sand/preview.png;sand/header.png;sand/footer.png;;#000000;#ffffff green;Green;green/preview.png;green/header.png;green/footer.png;;#000000;#ffffff The dark Personas line has one less ; (semi-colon) between the FOOTER.PNG and the first colour selection #RGB indicator. I suspect this is the correct line and the others have an extra ; (semi-colon), Which is the correct option? (In reply to Peter Maunder from comment #13) > The personas_list.txt appears to have inconsistent line entries. For example > the default on in 6.2 on my system is. > > white;White;white/preview.png;white/header.png;white/footer.png;;#000000; > #ffffff > gray;Gray;gray/preview.png;gray/header.png;gray/footer.png;;#000000;#ffffff > dark;Dark;dark/preview.png;dark/header.png;dark/footer.png;#ffffff;#000000 > pink;Pink;pink/preview.png;pink/header.png;pink/footer.png;;#000000;#ffffff > sand;Sand;sand/preview.png;sand/header.png;sand/footer.png;;#000000;#ffffff > green;Green;green/preview.png;green/header.png;green/footer.png;;#000000; > #ffffff > > The dark Personas line has one less ; (semi-colon) between the FOOTER.PNG > and the first colour selection #RGB indicator. I suspect this is the correct > line and the others have an extra ; (semi-colon), > > Which is the correct option? I have no idea how those extra ; chars slipped in. Good cache! I have taken a look at the API results, and it looks like that MOZ API no longer gives detailed info about personas (file urls), and it gives a single url to an xpi file instead. And the footer part seems to be gone (by looking into the unzipped zpi file). I have checked a few personas, and there were only the header files. I confirm that the footers are gone for good. I propose disabling the "Load Firefox theme" button (with a tooltip like "The Mozilla Themes API is currently unreachable.") until we figure out what to do with these changes. *** Bug 123781 has been marked as a duplicate of this bug. *** The problem has not been solved with version 6.2.1, it's still the same. *** Bug 123955 has been marked as a duplicate of this bug. *** *** Bug 124228 has been marked as a duplicate of this bug. *** *** Bug 124311 has been marked as a duplicate of this bug. *** If I am understanding this correctly then both bugs 123228 and 124311 are marked as duplicates of each other? Shouldn't it be only one direction? *** Bug 124404 has been marked as a duplicate of this bug. *** *** Bug 123911 has been marked as a duplicate of this bug. *** 6.2.3 has also not solved the problem. Muhammet Kara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/0d28abe085293604eb3127626da9c5a520b25c21%5E%21 tdf#123228: Disable Firefox theme search It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Muhammet Kara committed a patch related to this issue. It has been pushed to "libreoffice-6-2": https://git.libreoffice.org/core/+/872e2463da2c3f0f50536fbf68a594631e9a7740%5E%21 tdf#123228: Disable Firefox theme search It will be available in 6.2.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Sounds good - my thanks to Muhammet! :) Is there any chance of investigating an easy interface to already downloaded personas in the user profile when revising the personalisation? *** Bug 125209 has been marked as a duplicate of this bug. *** Disabling cannot be the final solution, can it? (In reply to Max Merbald from comment #31) > Disabling cannot be the final solution, can it? Definitely not. I'm also wondering how it works. If we can download and apply Firefox theme before, then there should be a way to manually download the theme and apply it. However I couldn't find the way either. In reply to Tim Chambers from comment #29) > Is there any chance of investigating an easy interface to already downloaded > personas in the user profile when revising the personalisation? Yep. That's intended. (In reply to Max Merbald from comment #31) > Disabling cannot be the final solution, can it? Unfortunately it is, unless someone find a way to access the data which was removed from all themes by Mozilla. (the footer images) (In reply to Franklin Weng from comment #32) > (In reply to Max Merbald from comment #31) > > Disabling cannot be the final solution, can it? > > Definitely not. I'm also wondering how it works. If we can download and > apply Firefox theme before, then there should be a way to manually download > the theme and apply it. However I couldn't find the way either. Problem is not downloading but the content. The same theme downloaded a year ago and now are different. Current themes are missing the footer images. That sounds more complicateed than I thought when I filed the bug. Anyway, just 6 different colours to personalise LO is not a big lot. Well, I guess it's going to take a while to find a solution. Thank you anyway for your work! I think it would be nice if you could just use an image from your computer to personalise LO. *** Bug 126502 has been marked as a duplicate of this bug. *** How are things looking? So far you don't seem to have found a solution. |