Summary: | Changing units in paragraph style dialog's Font tab sets value to 0 | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Buovjaga <ilmari.lauhakangas> |
Component: | Writer | Assignee: | Caolán McNamara <caolan.mcnamara> |
Status: | VERIFIED FIXED | ||
Severity: | minor | CC: | caolan.mcnamara, dgp-mail, telesto, xiscofauli |
Priority: | medium | Keywords: | bibisected, bisected, regression |
Version: | 6.2.0.0.alpha0+ | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | target:6.3.0 target:6.2.1 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 108456 | ||
Attachments: | Test file |
Description
Buovjaga
2019-01-15 20:33:29 UTC
No issue for me Version: 6.3.0.0.alpha0+ Build ID: 61778fd20395794d2de3b52d60dcc65083aecd93 CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; Locale: nl-NL (nl_NL); UI-Language: en-US Calc: threaded Maybe UI-Language depended? I can't reproduce it in Version: 6.3.0.0.alpha0+ Build ID: c977473546e450ec122f5d3dbc4578d8994962ef CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: x11; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded Created attachment 148351 [details]
Test file
Ok, try with a test file from the other bug, modify Heading 1.
Can't reproduce with frile from comment 3 and Version: 6.3.0.0.alpha0+ (x64) Build ID: 411f3a050ac2be598019d512f8ccfe041080c28f CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; TinderBox: Win-x86_64@42, Branch:master, Time: 2019-01-14_03:17:11 Locale: en-US (de_DE); UI-Language: en-US Calc: threaded So just to make it clear, Xisco, Telesto, Dieter: in step 3, you delete the whole contents of Size and input "pt". None of you mentioned the result you get instead of 0. If you get "13", you see the old behaviour. It is not dependent on locale or UI lang, see the values in: Version: 6.3.0.0.alpha0+ Build ID: c977473546e450ec122f5d3dbc4578d8994962ef CPU threads: 8; OS: Linux 4.20; UI render: default; VCL: x11; Locale: en-US (en_US.utf8); UI-Language: en-US Calc: threaded (In reply to Buovjaga from comment #5) > So just to make it clear, Xisco, Telesto, Dieter: in step 3, you delete the > whole contents of Size and input "pt". Thank you for clarification. Now I could reproduce it. After input only pt I got the following result: - Size changes to 12 pt. - Dialog shows size of 0 pt - Size in toolbar shows 2 Reproducible indeed :-) "On Linux you have to reopen the dialog to see the change", it should be sufficient to put the focus into another widget, e.g. font name overwriting with "pt" afaics never *converted* the previous value to point, just flipped the widget into point mode and fairly randomly reused the previously set value reinterpreted as points with a single decimal place. interpreting "pt" as "0 pt" seems valid to me, but with a bug that the values are supposed to be limited to a min/max which got lost along, i.e. the 0 shouldn't be possible and should end up as 2pt, like how the toolbar one is limited. Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/edf8e2b6630ca9cf7117d9c7a25ef9d7231c5a9b%5E%21 Resolves: tdf#122744 pt/% values not limited to historic limits It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. we now should not end up with a 0 value, backport to 6-2 in gerrit Confirmed the fix, thanks. Arch Linux 64-bit Version: 6.3.0.0.alpha0+ Build ID: 276b46ee53b82f409a451ae8324c1a12e2abb38e CPU threads: 8; OS: Linux 4.20; UI render: default; VCL: gtk3; Locale: fi-FI (fi_FI.UTF-8); UI-Language: en-US Calc: threaded Built on 16 January 2019 Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-6-2": https://git.libreoffice.org/core/+/39bee8a2e148dae05cb65778d1b21c9ea9c97dc4%5E%21 Resolves: tdf#122744 pt/% values not limited to historic limits It will be available in 6.2.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |