Bug 122633

Summary: New Print dialog: default setting of Preview is Off
Product: LibreOffice Reporter: Gabor Kelemen (allotropia) <kelemeng>
Component: UIAssignee: Heiko Tietze <heiko.tietze>
Status: VERIFIED FIXED    
Severity: trivial CC: buzea.bogdan, cno, danielfaleirosilva, fitojb, heiko.tietze, himajin100000, libreoffice, xiscofauli
Priority: medium    
Version: 6.2.0.1 rc   
Hardware: All   
OS: All   
See Also: https://bugs.documentfoundation.org/show_bug.cgi?id=67905
Whiteboard: target:6.3.0
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 103309    
Attachments: Screenshot of the Print window

Description Gabor Kelemen (allotropia) 2019-01-10 12:49:27 UTC
Created attachment 148216 [details]
Screenshot of the Print window

The default setting of the Preview square at the bottom left of the Print dialog is off.
I think it should be turned on by default, like in the previous version.

Version: 6.3.0.0.alpha0+
Build ID: 17dd2662ccfa9d04efbea74e5d7548db5b2126d4
CPU threads: 4; OS: Windows 6.3; UI render: GL; VCL: win; 
Locale: hu-HU (hu_HU); UI-Language: en-US
Calc:
Comment 1 Cor Nouws 2019-01-10 13:57:44 UTC
(In reply to Gabor Kelemen from comment #0)

> I think it should be turned on by default, like in the previous version.

The choice was to have it off, preventing delay issues.
OTOH, if one can turn it off and it keeps that setting, it would be fine too.
Comment 2 Timur 2019-01-10 15:19:47 UTC
From what I see, Preview checkbox remembers the last setting.
Comment 3 Heiko Tietze 2019-01-14 09:50:54 UTC
The checkbox is set to active in the UI file. Don't see where the option is switched off (neither how it's stored). So could you please take a look, Daniel.
Comment 4 Gabor Kelemen (allotropia) 2019-01-14 23:18:00 UTC
(In reply to Cor Nouws from comment #1)
> (In reply to Gabor Kelemen from comment #0)
> 
> > I think it should be turned on by default, like in the previous version.
> 
> The choice was to have it off, preventing delay issues.
> OTOH, if one can turn it off and it keeps that setting, it would be fine too.

I see, it was bug #67905 - but in most desktop use cases I think there is enough processing power for the preview rendering, while I understand there are situations when there isn't.
But this is a VERY UX question :).

@Heiko:
About turning it on / off by default, there is this key (without an xcs schema... would be nicer to have) under  ooo.VCL/PrintDialog/HasPreview that is not set by default and the code interprets != "true" (including: empty) as a false value; see vcl/source/window/printdlg.cxx see void PrintDialog::readFromSettings()
Comment 5 Heiko Tietze 2019-01-15 08:40:12 UTC
Changed the default to true https://gerrit.libreoffice.org/#/c/66351/ but that's effective only when there is no registry, ie. completely new installation. Not a big deal anyway.
Comment 6 Commit Notification 2019-01-15 13:04:12 UTC
heiko tietze committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/dcf185ea162a4f593c66639cb3aebdc9c3d1a60f%5E%21

Resolves: tdf#122633 - Print dialog Preview is Off

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 BogdanB 2019-01-26 13:48:44 UTC
Yes, I noticed this bug and was annoing. It's gone now.

Fixed. Verified on
Version: 6.3.0.0.alpha0+
Build ID: 3424004cca7cb61043800f0ff0acc9de64768276
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2019-01-26_00:45:09
Locale: ro-RO (ro_RO.UTF-8); UI-Language: en-US
Calc: threaded