Summary: | Index filter results will be reset after clicking one of the entries | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Franklin Weng <franklin> |
Component: | Documentation | Assignee: | Not Assigned <libreoffice-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | CC: | heiko.tietze, ilmari.lauhakangas, olivier.hallot, xiscofauli |
Priority: | medium | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | target:6.3.0 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 97629 |
Description
Franklin Weng
2018-12-29 01:38:53 UTC
confirmed. This request will conflict with the feature of bug 119415. Note that you will not see the feature in action if visiting the old version https://help.libreoffice.org/6.1 - you have to visit https://help.libreoffice.org/6.2 Now, after implementing the request of bug 119415, the index will *always* change, if you click on any other topic besides GLOBAL. If we try to implement Franklin's request, the result will *always* be lacking and not be what Franklin wants. Franklin's search results would never be 100% preserved, if he clicked some other topic besides GLOBAL. Therefore I do not know, if this request should be implemented. When a filter (module here) is set by the user this has to be respected. So I would keep the filter active. But in the current solution it's not transparent what module has been selected. So my proposal is to add "All Modules" to the list and change the label according what is selected. Furthermore, I would keep the search term alive when the module is changed and restart the search. (In reply to Buovjaga from comment #2) > This request will conflict with the feature of bug 119415. Note that you > will not see the feature in action if visiting the old version > https://help.libreoffice.org/6.1 - you have to visit > https://help.libreoffice.org/6.2 The links went to the old wiki. This is the correct link: https://helponline.libreoffice.org/6.2/ Someone else can implement this how they want. Removing myself. Ilmari Lauhakangas committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/help/+/578f74466fcbf2dca537859e73064bfb4583928a%5E%21 tdf#122366 Store search filter value in sessionStorage Would be great to hear opinions on the patch. Is sessionStorage enough or is localStorage needed? Mike's bug 123318 is touching on the other stuff mentioned in this report (Heiko's "my proposal is to add "All Modules" to the list and change the label according what is selected"). No feedback in 2,5 years, so I guess this is fine now. |