Summary: | Assertion "SolarMutex not owned!" fails when resizing image | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Stephan Bergmann <sberg.fun> |
Component: | LibreOffice | Assignee: | Not Assigned <libreoffice-bugs> |
Status: | VERIFIED FIXED | ||
Severity: | normal | CC: | glogow, iplaw67, tml, xiscofauli |
Priority: | medium | ||
Version: | 6.2.0.0.alpha0+ | ||
Hardware: | All | ||
OS: | macOS (All) | ||
Whiteboard: | target:6.3.0 target:6.2.0.1 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 105537 |
Description
Stephan Bergmann
2018-10-05 11:52:50 UTC
Hmm, no repro for me with my own master build from last night (04/10): Version: 6.2.0.0.alpha0+ Build ID: b24ab600b06c4aed43552544b4ef575649c93ee9 CPU threads: 4; OS: Mac OS X 10.13.6; UI render: default; VCL: osx; Locale: fr-FR (fr_FR.UTF-8); Calc: threaded using an inserted TIFF image. Haven't yet upgraded OS to 10.14 (In reply to Alex Thurgood from comment #1) > Hmm, no repro for me with my own master build from last night (04/10): (Note, just in case: you need an --enable-assert-always-abort (i.e., --enable-debug or --enable-dbgutil) build for asserts to actually fire.) (In reply to Stephan Bergmann from comment #2) > (Note, just in case: you need an --enable-assert-always-abort (i.e., > --enable-debug or --enable-dbgutil) build for asserts to actually fire.) Ah, OK, I only have a --enable-symbols build Effectively the same happens when you click the green title bar button of e.g. a Calc document window, to maximize that window: AquaSalInstance::DoYield calls [VCL_NSApplication sendEvent:] calls into OS code, gets out at [SalFrameView drawRect:], which calls Scheduler::ProcessTaskScheduling but with the SolarMutex not locked. Confirmed per Tor's report in bug 120542 *** Bug 120542 has been marked as a duplicate of this bug. *** Jan-Marek Glogowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/d59e44bc18bea4bccfa87865200d889f65e10bf1%5E%21 tdf#120342 OSX always lock SolarMutex in drawRect It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Cannot reproduce the asserts from comment 0 and comment 4 in a local (debug) build containing the commit from comment 7 on macOS 10.14. Jan-Marek Glogowski committed a patch related to this issue. It has been pushed to "libreoffice-6-2": https://git.libreoffice.org/core/+/7038756003818f9c98866fa30316950172281043%5E%21 tdf#120342 OSX always lock SolarMutex in drawRect It will be available in 6.2.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |