Summary: | Undo for image deletion does not restore animations | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Diogo G. Sousa <diogogsousa> |
Component: | Impress | Assignee: | Not Assigned <libreoffice-bugs> |
Status: | NEW --- | ||
Severity: | normal | CC: | caolan.mcnamara, eyalroz1, noreply+69259, ravingdesi, telesto, xiscofauli |
Priority: | medium | Keywords: | bibisected, bisected, regression |
Version: | 4.1 all versions | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=112696 https://bugs.documentfoundation.org/show_bug.cgi?id=89389 https://bugs.documentfoundation.org/show_bug.cgi?id=135033 https://bugs.documentfoundation.org/show_bug.cgi?id=156494 |
||
Whiteboard: | |||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 105948, 109362 | ||
Attachments: | Impress - animation not restored after undo |
Description
Diogo G. Sousa
2018-08-26 17:51:46 UTC
Seems to be related, if not a duplicate, of Bug 83882. Regression introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=57082b1243e86694b72c5e4fad013bf207bfe81a author Luke Deller <luke@deller.id.au> 2013-04-28 07:06:11 +1000 committer David Tardon <dtardon@redhat.com> 2013-04-28 11:52:12 +0000 commit 57082b1243e86694b72c5e4fad013bf207bfe81a (patch) tree 2e461c166beecb5b569c966a2aeceb90995a4b85 parent 2094610175140023cf8f904f8506c189e36dec06 (diff) fdo#60910: discard UNO shape object in SdrObject::SetPage The creation of the UNO shape in SdrObject::getUnoShape is influenced by pPage, so when the page changes we need to discard the cached UNO shape so that a new one will be created with the new page. This replaces my first shot at a fix for fdo#60910 which reinstated a line to discard the custom shape engine (and consequently the UNO shape) in SdrObjCustomShape::InvalidateRenderGeometry. That worked but did more discarding than was necessary. Bisected with: bibisect-41max Adding Cc: to Luke Deller *** Bug 83882 has been marked as a duplicate of this bug. *** *** Bug 83928 has been marked as a duplicate of this bug. *** Still reproduced in Version: 6.3.0.0.alpha0+ Build ID: 00df4a5ae395607eab1f83aacfc1fb05eb93ecc9 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded @Caolán, since you fixed bug 112696, I thought you might be interested in this issue... Still happening with 6.3 Microsoft PowerPoint works! I can reproduce this exact behavior in 7.0RC2 *** Bug 136288 has been marked as a duplicate of this bug. *** Isn't this just a special case of the fact that there is no undo support for changes/additions/removals of animations, period? Please explain why not or mark as a duplicate of bug 135033. Created attachment 180259 [details] Impress - animation not restored after undo I can confirm and the bug still exists. Version: 7.3.3.2 / LibreOffice Community Build ID: d1d0ea68f081ee2800a922cac8f79445e4603348 CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: gtk3 Locale: de-AT (de_AT.UTF-8); UI: de-DE Flatpak Calc: threaded |