Summary: | VBA macro unnecessarily recalculated | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Aron Budea <aron.budea> |
Component: | Calc | Assignee: | Mike Kaganski <mikekaganski> |
Status: | RESOLVED FIXED | ||
Severity: | normal | Keywords: | implementationError, perf |
Priority: | medium | ||
Version: | 4.3.0.4 release | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | target:6.2.0 target:6.1.0.1 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 108908 | ||
Attachments: | Sample XLSM |
Already opens slowly in 4.3.0.4, and in 4.2.0.4 the macro isn't executed at all. => implementation error Confirmed that both using "Never recalculate" and "Always recalculate" for "Recalculation on file load"->"Excel 2007 and newer", the opening time is ~same long (with recalculation), while it should be much shorter for the "Never recalculate" case. Tested with Version: 6.0.5.2 (x64) Build ID: 54c8cbb85f300ac59db32fe8a675ff7683cd5a16 CPU threads: 4; OS: Windows 10.0; UI render: default; Locale: ru-RU (ru_RU); Calc: CL Mike Kaganski committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=e6c43ed9e6bb41b64bcc8105ad006c999deebcd7 tdf#118441: also keep string-formula results for shared formulas It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Mike Kaganski committed a patch related to this issue. It has been pushed to "libreoffice-6-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=ee0d0b0d21889441dec04c3b17fc99087cf8ef96&h=libreoffice-6-1 tdf#118441: also keep string-formula results for shared formulas It will be available in 6.1.0.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |
Created attachment 143195 [details] Sample XLSM The attached XLSM spreadsheet contains 7000 rows with a simple summation macro (sums values in B-Z columns, which aren't filled, so the result is always 0). In Excel the file opens in ~1s. In Calc it opens in ~23s. If macros are disabled, rows 2-7000 show #VALUE! error, which means those are the ones being calculated, when they shouldn't. Observed using LO 6.1 beta2 / Windows 7.