Summary: | FILESAVE PDF The Option Button Form Control lost the “Group Name” setting | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Gabor Kelemen (allotropia) <kelemeng> |
Component: | Printing and PDF export | Assignee: | Justin L <jluth> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | ilmari.lauhakangas, jluth, libreoffice |
Priority: | medium | ||
Version: | Inherited From OOo | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=79542 | ||
Whiteboard: | target:6.2.0 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 116702 | ||
Attachments: |
Example odt with multiple option buttons
Group name is set in the properties Exported file in Acrobat Reader XI - all options can be selected optionButtons.odt: make sure two option groups still work (and bug 108687 test) |
Description
Gabor Kelemen (allotropia)
2018-06-19 16:00:10 UTC
Created attachment 142925 [details]
Group name is set in the properties
Created attachment 142926 [details]
Exported file in Acrobat Reader XI - all options can be selected
Repro. Version: 6.2.0.0.alpha0+ (x64) Build ID: 2c85607101e2e04e870e3b87362f39f9a9148e6c CPU threads: 4; OS: Windows 10.0; UI render: default; TinderBox: Win-x86_64@42, Branch:master, Time: 2018-06-16_00:12:37 Locale: fi-FI (fi_FI); Calc: group threaded 3.3.0 A workaround is to give each option button NAME to be identical. The code for this is in toolbox/source/helper/formpdfexport.cxx determineRadioGroupId(). But this is really scary code because it looks like it is doing it all wrong, and did anyone even test this when they coded it? And if this is working for some specific situation, then changes would break that. Git history doesn't help much - basically unmodified since initial code dump at commit cda7d3dc154a74cd914bf21bc7eeb8c43bb6e154 Author: Vladimir Glazounov <vg@openoffice.org> Date: Tue Aug 19 21:10:58 2008 +0000 INTEGRATION: CWS aw033 (1.1.2); FILE ADDED 2008/08/19 16:46:47 cl 1.1.2.2: fixed license files 2007/08/07 15:40:47 aw 1.1.2.1: #i39532# migrated describePDFControl to toolkit I'm going to guess at what happened here. Likely, originally OOo implemented radio button groupping by assigning the same name to each button. Then at some point they added the "GroupName" property to the radio button to store that information, but the PDF export code was never modified. That is the only explanation that I can think of that would make sense of this situation. proposed fix at https://gerrit.libreoffice.org/62742 Created attachment 146267 [details] optionButtons.odt: make sure two option groups still work (and bug 108687 test) My proposed patch didn't accept the previous behaviour. That might be OK if necessary, but it should be possible to support both methods, so that people who have spent a lot time figuring out how to work around LibreOffice's poor PDF export of radio buttons don't have to redesign just because GroupNamme is now supported. Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/80400973e06e08f0c1ab0b9a86418c1bcc4bbd5c%5E%21 tdf#118244 pdfexport: radio buttons use groupname now It will be available in 6.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/655154e45abfe6c69b97ad5c615f231be4b3827a%5E%21 tdf#118244 pdfexport: radio buttons can group with same name It will be available in 6.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |