Summary: | Keyboard accelerator underlines are not hidden correctly when ALT key is released with libreoffice-gtk | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Simon Long <simon> |
Component: | UI | Assignee: | Not Assigned <libreoffice-bugs> |
Status: | RESOLVED WORKSFORME | ||
Severity: | normal | CC: | caolan.mcnamara, fitojb, foss, jbfaure, samuel.mehrbrodt, vsfoote |
Priority: | medium | ||
Version: | 5.2 all versions | ||
Hardware: | ARM | ||
OS: | Linux (All) | ||
See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=99326 https://bugs.documentfoundation.org/show_bug.cgi?id=92630 |
||
Whiteboard: | |||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 98529 |
Description
Simon Long
2018-06-15 20:42:03 UTC
(In reply to Simon Long from comment #0) > Description: > A couple of years ago I produced a patch which enabled GTK-2 and -3 > accelerator underline autohide when using libreoffice-gtk. When accelerator > autohide is enabled in the GTK theme, the underscores in menus etc should > only be shown while the ALT key is held down; they should be hidden the rest > of the time. This worked well in LO 4. > > This behaviour has not been correctly ported to LO 5 - on the main menu bar > at the top of an application window, the accelerator underlines are > initially hidden (which is correct), and they are shown when the ALT key is > pressed (which is also correct), but they remain visible when the ALT key is > released (which is not correct). They are only hidden again when a menu is > closed by pressing ESC. If ALT is pressed and released without an > accelerator key being pressed as well, the underlines remain on the menu and > cannot be removed. > ... OK, that was bug 92630 and https://gerrit.libreoffice.org/#/c/16868/ rebased to master by Samuel M. https://gerrit.libreoffice.org/#/c/16883/ which was only implemented at 5.1.0 Fair bit of work since then, any better with a 6.1 release or current master/6.2? As with the wontfix handling of bug 97260 -- this mishandling of the visibility with GTK+ themes should be corrected for GTK+ normalcy. But need to also recognize lingering issues like bug 54169 continue to affect non-GTK OS/DE I couldn't reproduce the issue on Debian Stretch with GTK 3.22.11 and LibreOffice 6.0.5. What is your distribution and GTK 3 version ? Best regards, ALex. Not reproducible under Ubuntu (Unity) 16.04 x86-64 with LibreOffice 6.0.4 from Ubuntu PPA and using GTK3. Best regards. JBF (In reply to Alex ARNAUD from comment #2) > I couldn't reproduce the issue on Debian Stretch with GTK 3.22.11 and > LibreOffice 6.0.5. > > What is your distribution and GTK 3 version ? > > Best regards, > ALex. Debian (Raspbian) Stretch, with GTK 3.22.11. I'll try downloading LO 6 and see if it's fixed in there. Just tried LibreOffice 6.0.5.1 on Stretch and GTK 3.22.11 - that does indeed work fine and does not have the same bug. Looks like it is only LibreOffice 5 which is affected. (In reply to Simon Long from comment #5) > Just tried LibreOffice 6.0.5.1 on Stretch and GTK 3.22.11 - that does indeed > work fine and does not have the same bug. Looks like it is only LibreOffice > 5 which is affected. Thanks for the confirmation. I'm moving the status to resolved as it now works correctly on latest stable version. Best regards, Alex. |