| Summary: | Accessible text-attributes-changed signals should only be emitted when the text attributes have changed [a11y] second attempt | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Michael Stahl (allotropia) <michael.stahl> |
| Component: | Writer | Assignee: | Not Assigned <libreoffice-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | Armin.Le.Grand, foss, jaragunde, jean-philippe.mengual, marina.latini, michael.meeks, noelgrandin, patrick, vmiklos, xiscofauli |
| Priority: | medium | Keywords: | accessibility, regression |
| Version: | 6.2.0.0.alpha0+ | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=71556 https://bugs.documentfoundation.org/show_bug.cgi?id=104351 |
||
| Whiteboard: | target:6.3.0 target:6.2.1 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 101912 | ||
|
Description
Michael Stahl (allotropia)
2018-05-31 14:41:32 UTC
Noel likes to work in sw... Dear Noel Grandin, This bug has been in ASSIGNED status for more than 3 months without any activity. Resetting it to NEW. Please assigned it back to yourself if you're still working on this. Hello all, I would like to bring your attention on this accessibility regression that has been discovered on may 31st, 2018, yet that it still awaiting a fix although it probably is a mere matter of reverting an unfortunate mistake. As TDF would like to avoid accessibility regressions, could it be possible to have CIB or Collabora support on this? Thanks in advance. Best regards, Alex. Hmm; so part of Armin's DrawingLayer work somehow dropped Joan Marie's patch from bug#71556 - https://cgit.freedesktop.org/libreoffice/core/commit/?id=dddae1f0b950f1ce8ab4bcd24991f1917fa36aa6 that caused the problem ? Any thoughts Armin ? Alex - all regressions are bad: this is not a trivial reversion: you're encouraged to look into it yourself too. I have a fix for this in-progress at https://gerrit.libreoffice.org/#/c/66719/1 Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/f9fe988b7f463bc221dd3b67dcf0ed39309f921a%5E%21 tdf#117935 Accessible text-attributes-changed signals... It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Noel Grandin committed a patch related to this issue. It has been pushed to "libreoffice-6-2": https://git.libreoffice.org/core/+/39d6804454f60fb9ba442f85a0487898dfe68e69%5E%21 tdf#117935 Accessible text-attributes-changed signals... It will be available in 6.2.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Should it be backported to 6-1 branch ? |