Summary: | FILESAVE: RTF: Incorrect cell width after RT (in MSO) | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Xisco Faulí <xiscofauli> |
Component: | Writer | Assignee: | Mike Kaganski <mikekaganski> |
Status: | VERIFIED FIXED | ||
Severity: | normal | CC: | mikekaganski, xiscofauli |
Priority: | medium | Keywords: | bibisected, bisected, filter:rtf, regression |
Version: | 6.1.0.0.alpha0+ | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | target:6.1.0 | ||
Crash report or crash signature: | Regression By: | ||
Attachments: |
comparison MSO 2010 and LibreOffice 6.1
sample1 problem with table after RT |
Description
Xisco Faulí
2018-01-23 18:51:59 UTC
Created attachment 139301 [details]
sample1
Another file where the issue is reproduced but only if the file is open in MSO 2010 after the RT
attachment 95033 [details] from bug 119587 is also affected if the file is open in MSO Word 2010 Regression introduced by: author Mike Kaganski <mike.kaganski@collabora.com> 2017-12-08 17:52:56 +0300 committer Mike Kaganski <mike.kaganski@collabora.com> 2017-12-11 11:58:24 +0100 commit 0f9a596aa853b4f2beeff25c131246a7b31492a4 (patch) tree 1145ce12578a21c151510dee03a5aefae9844276 parent 12efb01e38f94992ce746d20d40410229c431225 (diff) tdf#114333: consider trleft for 1st cell width on import; don't... ... recalculate cell widths by factor pagewidth/tablewidth on export This makes the import and export symmetrical. Bisected with: bibisect-linux64-6.1 Adding Cc: to Mike Kaganski attachment 119587 [details] from bug 95033 is also affected if the file is open in MSO Word 2010 Created attachment 139302 [details] problem with table after RT This also affects the tables after RT -> attachment 98679 [details] from bug 78433 @Mike, Should I report a new issue for this one ? (In reply to Xisco Faulí from comment #5) > @Mike, Should I report a new issue for this one ? No need; https://gerrit.libreoffice.org/48501 takes care of all these cases AFAICS. (In reply to Mike Kaganski from comment #6) > (In reply to Xisco Faulí from comment #5) > > @Mike, Should I report a new issue for this one ? > > No need; https://gerrit.libreoffice.org/48501 takes care of all these cases > AFAICS. Hi Mike, Thanks for the quick fix. Ok, once it's merged, I'll test it with all the documents I have here showing the problem. If I find any other, I'll report a different bug then. Thanks! Mike Kaganski committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=d91236ad8fc74e1ec15c39b90660717ebab013ac tdf#115180: take table base width into account It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Verified in Version: 6.1.0.0.alpha0+ Build ID: 5cb225b0b3dbb55fd44899b1fb16bdcfeb866849 CPU threads: 4; OS: Linux 4.10; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: group threaded @Mike, could you please backport it to 6-0 ? ah, forget it, the other commit is not in 6-0 branch. Thanks for the fix!! |