Summary: | Proxy settings disregarded for reporting crashes | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Aron Budea <aron.budea> |
Component: | LibreOffice | Assignee: | Not Assigned <libreoffice-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | himajin100000, markus.mohrhard, michael.meeks, mikekaganski, xiscofauli |
Priority: | medium | ||
Version: | 5.3 all versions | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | target:6.1.0 target:6.2.0 target:6.1.0.1 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 113285 |
Description
Aron Budea
2017-12-04 03:28:42 UTC
The first problem - of not including the proxy settings is presumably fixable; but the 2nd - is harder (I guess) firefox had some similar issues: https://bugzilla.mozilla.org/show_bug.cgi?format=default&id=464429 and: https://bugs.chromium.org/p/google-breakpad/issues/detail?id=232 There is an incomplete patch on gerrit: https://gerrit.libreoffice.org/#/c/51621/ This handles the fixed proxy setting coming from LibreOffice, but that is highly undesirable because of a serious problem with that dialog: bug 33697. Additionally, it doesn't handle automatic configuration scripts, because ucbhelper::InternetProxyDecider can't handle those, either. Adding that support would be a large-scale change with risks, plus rounding out the OS-dependent parts might be difficult. And for crash reporter, Windows is the most important, so adding a Windows-specific query in CrashReporter::writeCommonInfo() could be a sufficient measure (maybe WinHttpGetProxyForUrl() [1]). If that returns no proxy, then LO setting can be queried, otherwise use what Windows provides. [1] https://msdn.microsoft.com/en-us/library/windows/desktop/aa384097(v=vs.85).aspx Aron Budea committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=07174b62c6ee23f7b44742ecfe44d4ff8653e57f tdf#114227: set better proxy params in cURL for crash reporting It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. A polite ping to Aron Budea: Is this bug fixed? if so, could you please close it as RESOLVED FIXED ? Otherwise, Could you please explain what's missing? Thanks Mike Kaganski committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=2e142c0ee54744d35517f0b9c49a24302fb32d47 tdf#114227: Add support for PAC to ucbhelper::InternetProxyDecider on Windows It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Noel Grandin committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=0e375686e2f2c6c626f50c06c5323c0982d7f602 tdf#114227 Add support for OS proxy to ucbhelper::InternetProxyDecider on Unix It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Mike Kaganski committed a patch related to this issue. It has been pushed to "libreoffice-6-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=76c0b3c516f6b0d43136522b4d476eb60211cec1&h=libreoffice-6-1 tdf#114227: Add support for PAC to ucbhelper::InternetProxyDecider on Windows It will be available in 6.1.0.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |