Summary: | FILEOPEN: Text on OLE object is not read | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Regina Henschel <rb.henschel> |
Component: | LibreOffice | Assignee: | Regina Henschel <rb.henschel> |
Status: | CLOSED FIXED | ||
Severity: | normal | CC: | jalojo, xiscofauli |
Priority: | medium | ||
Version: | 4.0.0.3 release | ||
Hardware: | x86 (IA32) | ||
OS: | All | ||
Whiteboard: | target:6.0.0 target:5.4.4 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 107810 | ||
Attachments: | Collection of files with OLE objects |
Description
Regina Henschel
2017-09-21 10:12:22 UTC
Hi Regina, I reproduce with LO : 6.0.0.0.alpha0+ Build ID: e0aed1459513be5e08fab9de06848df5dc9d0b5f CPU threads: 2; OS: Windows 6.1; UI render: default; TinderBox: Win-x86@39, Branch:master, Time: 2017-09-20_06:45:25 Locale: fr-FR (fr_FR); Calc: CL If the text is in a <text:p> inside the <draw:object> element, then the text is shown. This construction was the original one inherited from AOO, but it is not valid to have a <text:p> element inside the <draw:object> element. When was the <text:p> element moved to the parent <draw:frame> element? Will try to fix it. This feature has been broken from the beginning, when the patch from https://bz.apache.org/ooo/show_bug.cgi?id=118485 was integrated in LibreOffice sometime 2012. The import expects, that the paragraph is inside the <draw:object> or <draw:object-ole> element respectivelly. But in contrast to AOO, in LO the paragraph is written one level higher outside of <draw:object> and <draw:object-ole> element. Because of comment #10 in the linked bug, I do not change the import to read the paragraph from the place LibreOffice writes it, but I change LibreOffice, so that it writes the paragraph into the <draw:object> element. To test the fix, you need to add text to Math-objects, Chart-objects and true OLE-objects. Save the documents and reload them. After reloading the text should be still there. The text may have several paragraphs and styled characters. *** Bug 106262 has been marked as a duplicate of this bug. *** Regina Henschel committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=21f61ffeb7e72caee98f12cac2dd25fe7ec3a821 tdf#112547 element p to draw:object, import expects it there It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Michael Stahl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=b3cfb849b19dc1e40c12586bebd2b76fc41007fa tdf#112547 sd: add unit test It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Regina Henschel committed a patch related to this issue. It has been pushed to "libreoffice-5-4": http://cgit.freedesktop.org/libreoffice/core/commit/?id=0958cd79545a21a37642f812937d57164117bffe&h=libreoffice-5-4 tdf#112547 element p to draw:object, import expects it there It will be available in 5.4.4. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. A polite ping to Regina Henschel: is this bug fixed? if so, could you please close it as RESOLVED FIXED ? Thanks It is fixed in Version: 6.1.0.0.alpha0+ (x64) Build ID: 401a3d2336bf46b38235c498ff86ff675d0de759 CPU threads: 8; OS: Windows 10.0; UI render: GL; TinderBox: Win-x86_64@42, Branch:master, Time: 2017-11-28_00:13:08 Locale: de-DE (de_DE); Calc: CL and in Version: 5.4.4.1 (x64) Build-ID: da790616461e15a10c95a80eb8ef8ee7b726c114 CPU-Threads: 8; BS: Windows 6.19; UI-Render: GL; Gebietsschema: de-DE (de_DE); Calc: CL |