Summary: | PPTX with shape having multiple effects opens with repair in PowerPoint after roundtrip | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Aron Budea <aron.budea> |
Component: | Impress | Assignee: | Tamás Zolnai <zolnaitamas2000> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | xiscofauli, zolnaitamas2000 |
Priority: | medium | Keywords: | bibisected, bisected, filter:pptx, regression |
Version: | 6.0.0.0.alpha0+ | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | target:6.0.0 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 104787 | ||
Attachments: | Sample PPTX |
Description
Aron Budea
2017-08-16 01:14:15 UTC
Created attachment 135569 [details]
Sample PPTX
The following daily build saves the file fine, this must be a fresh regression. 2017-08-11_06:44:17 (46b4eb8b0e9325f8c29cd391baf9504bccee1837) Confirmed in Version: 6.0.0.0.alpha0+ Build ID: a19dc104ec008f0bb44676d63d4764c6d7442a0d CPU threads: 4; OS: Linux 4.10; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: group Bug still in daily build 2017-09-04_00:07:35 (abe958a713ff0c26a3f91c558a2f227c1996c592). Bibisected to the following commit using bibisect-linux-64-6.0. Adding Cc: to Tamás Zolnai, please take a look sometimes. https://cgit.freedesktop.org/libreoffice/core/commit/?id=787732fac0aef255bdc51479fdaddf15532d118e author Tamás Zolnai <tamas.zolnai@collabora.com> 2017-08-14 04:11:14 (GMT) committer Tamás Zolnai <tamas.zolnai@collabora.com> 2017-08-14 05:37:23 (GMT) "Decrease duplicated code" In the bad XML the effects are listed like this: <a:effectLst> <a:glow rad="355600"> <a:schemeClr val="accent1"> <a:alpha val="40000"/> </a:schemeClr> </a:glow> </a:effectLst> <a:effectLst> <a:outerShdw algn="t" blurRad="76200" dir="2760000" dist="431800" rotWithShape="0"> <a:srgbClr val="000000"> <a:alpha val="40000"/> </a:srgbClr> </a:outerShdw> </a:effectLst> In the good version there's no </a:effectLst> / <a:effectLst> between the two effects. (In reply to Aron Budea from comment #5) > Bibisected to the following commit using bibisect-linux-64-6.0. Adding Cc: > to Tamás Zolnai, please take a look sometimes. > > https://cgit.freedesktop.org/libreoffice/core/commit/ > ?id=787732fac0aef255bdc51479fdaddf15532d118e > author Tamás Zolnai <tamas.zolnai@collabora.com> 2017-08-14 04:11:14 (GMT) > committer Tamás Zolnai <tamas.zolnai@collabora.com> 2017-08-14 05:37:23 (GMT) > > "Decrease duplicated code" Yeap, it was a dump mistake. I'll revert this commit. Thanks for bisecting the commit! Tamás Zolnai committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=f3f98b8e1f9eb0804e18bea055fb02917aca42a5 tdf#111838: Revert "Decrease duplicated code" It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |