| Summary: | Binary MS Office files identified as template when they're opened lacking file extension or with "wrong" file extension | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Aron Budea <aron.budea> |
| Component: | filters and storage | Assignee: | Not Assigned <libreoffice-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | tml, xiscofauli |
| Priority: | low | Keywords: | bibisected, bisected, regression |
| Version: | 4.1.0.4 release | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=119530 https://bugs.documentfoundation.org/show_bug.cgi?id=125216 https://bugs.documentfoundation.org/show_bug.cgi?id=129944 |
||
| Whiteboard: | target:6.3.0 target:6.2.2 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 104848, 123475 | ||
|
Description
Aron Budea
2017-08-01 13:13:16 UTC
# bad: [e8a1c54dfe8a4bc03d2ce9cb9906bf06d9affa7d] source-hash-863d38fbfa4fb4861e476828c46410602100919e # good: [8cb222c656c0444f66cfa5a35ed204169bb91e09] source-hash-efca6f15609322f62a35619619a6d5fe5c9bd5a4 git bisect start 'latest' 'oldest' # bad: [789cb134f3000918fe031ffce19c57e505cab328] source-hash-8669ad398a2971706ce22b6e5fe316991977452a git bisect bad 789cb134f3000918fe031ffce19c57e505cab328 # good: [995de0a4aa5e3a57df5ed558426ad9359bdb63fa] source-hash-32e3ede97ec6bad1b3c19545709b54eff29eafc6 git bisect good 995de0a4aa5e3a57df5ed558426ad9359bdb63fa # good: [06e3321c5c4f7f5a61cdc6a91b69cef541e7e9cd] source-hash-2926bd4d6bce5115e4de8e8e155cbeb9fd66e3a4 git bisect good 06e3321c5c4f7f5a61cdc6a91b69cef541e7e9cd # good: [1db175d953a03b6478121aeb8b545cb3f08615ea] source-hash-d97e6d1de52f5b3f1018e63aa78871aea1588b02 git bisect good 1db175d953a03b6478121aeb8b545cb3f08615ea # good: [4b6a04e680938c5c9961a910afa8e85ab8bb35b4] source-hash-edef1887ff9373b29228e51c44ae091f675a94aa git bisect good 4b6a04e680938c5c9961a910afa8e85ab8bb35b4 # bad: [d52e3b030bca8322cf1fef5e2e3b4f87a452e3ec] source-hash-0ed4da1a01e6cdfe44403a0686abe4aacea83dfb git bisect bad d52e3b030bca8322cf1fef5e2e3b4f87a452e3ec # skip: [6445976f8ec743325c23e7577eb5afb8115d3196] source-hash-6a2e8693b239b6d69523a34103b270613794ef8c git bisect skip 6445976f8ec743325c23e7577eb5afb8115d3196 # good: [90578f94936851f0fa52fa50e1b86c458114245d] source-hash-c79da6a42f1aa630435a1d2092580f3b1e9ff850 git bisect good 90578f94936851f0fa52fa50e1b86c458114245d # good: [3239b28031cb959e3f72057629feb006aabc0f87] source-hash-a3bb733ec6c6af04041c0b2a9849df22c26b3d29 git bisect good 3239b28031cb959e3f72057629feb006aabc0f87 # bad: [3f2766b183aa0d332e4a2e827f5b45b3ce6b741e] source-hash-e669502dcf2f825842ba87ee4a14a0be26883e28 git bisect bad 3f2766b183aa0d332e4a2e827f5b45b3ce6b741e # skip: [1e070af0a9c152d96cf1e2b3a7ab7ce9c4763029] source-hash-1a3c7b84b7b22109d691a770649af42c1033d709 git bisect skip 1e070af0a9c152d96cf1e2b3a7ab7ce9c4763029 # good: [a97ebe9fb337c83653a5fc153514f3a3000b44af] source-hash-c98a1fa04884c7fa34dfeb5e2eae706e57c09123 git bisect good a97ebe9fb337c83653a5fc153514f3a3000b44af # skip: [3249712fe0c6d8652dac4c96dd2975f9fbb7ce19] source-hash-c9fbcaa0b97c31216f5da8febd066a029c9bdef2 git bisect skip 3249712fe0c6d8652dac4c96dd2975f9fbb7ce19 # good: [3b65c4dec6ee392588c5d1c549f56d3a59efe3e2] source-hash-e721452988b54eb2e02c3885fde288be70bcf1f1 git bisect good 3b65c4dec6ee392588c5d1c549f56d3a59efe3e2 # bad: [2f850658679f37caf2b2c6225637e1f6dc892b16] source-hash-7e314a8331c91cce836237173bb9ba73edbd01c8 git bisect bad 2f850658679f37caf2b2c6225637e1f6dc892b16 # good: [564377b9e5991733a18e7238e5e4d1baebdf8375] source-hash-74d68ec05761b001bc82c1c9c2dc168648cde49b git bisect good 564377b9e5991733a18e7238e5e4d1baebdf8375 # bad: [e13801c3a8e0e60bd00e9fc9b9b838fee82a313a] source-hash-96c8251448646b65f6ea0b657417bca66d9a9b6e git bisect bad e13801c3a8e0e60bd00e9fc9b9b838fee82a313a # only skipped commits left to test # possible first bad commit: [e13801c3a8e0e60bd00e9fc9b9b838fee82a313a] source-hash-96c8251448646b65f6ea0b657417bca66d9a9b6e # possible first bad commit: [3249712fe0c6d8652dac4c96dd2975f9fbb7ce19] source-hash-c9fbcaa0b97c31216f5da8febd066a029c9bdef2 # possible first bad commit: [1e070af0a9c152d96cf1e2b3a7ab7ce9c4763029] source-hash-1a3c7b84b7b22109d691a770649af42c1033d709 One of these: https://cgit.freedesktop.org/libreoffice/core/commit/?id=1a3c7b84b7b22109d691a770649af42c1033d709 author Kohei Yoshida <kohei.yoshida@gmail.com> 2013-03-06 07:00:02 (GMT) committer Kohei Yoshida <kohei.yoshida@gmail.com> 2013-03-07 06:44:45 (GMT) Test all file format types regardless of document services. https://cgit.freedesktop.org/libreoffice/core/commit/?id=c9fbcaa0b97c31216f5da8febd066a029c9bdef2 author Kohei Yoshida <kohei.yoshida@gmail.com> 2013-03-06 21:27:23 (GMT) committer Kohei Yoshida <kohei.yoshida@gmail.com> 2013-03-07 06:44:46 (GMT) Reject type detection for zip formats when the stream is not a zip archive. https://cgit.freedesktop.org/libreoffice/core/commit/?id=96c8251448646b65f6ea0b657417bca66d9a9b6e author Kohei Yoshida <kohei.yoshida@gmail.com> 2013-03-07 05:28:00 (GMT) committer Kohei Yoshida <kohei.yoshida@gmail.com> 2013-03-07 06:44:46 (GMT) fdo#60562: List *all* format types that we support and rank them all properly. Binary Excel and PowerPoint formats are also affected. Dear Aron Budea, This bug has been in ASSIGNED status for more than 3 months without any activity. Resetting it to NEW. Please assigned it back to yourself if you're still working on this. Aron Budea committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=c1817a5b12da642e365a3ef72b556d33c6e29a76 tdf#110987: type detection, binary Office formats > templates It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Needs unit test. Aron Budea committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=1bb732acc6b4d3de94f343041472ccc096723b30 Revert "tdf#110987: type detection, binary Office formats > templates" It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. The commit in comment 5 caused a regression, no idea why, it doesn't seem to be diretly related, but perhaps for embedded documents them opening as template mattered. *** Bug 123545 has been marked as a duplicate of this bug. *** This bug fires also when a .doc file has been renamed to have another extension, at least .rtf. Tor Lillqvist committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/65559252f138aada7a55d3c5fe0a932a222d13e0%5E%21 tdf#110987: Don't mis-detect .doc files as .dot It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Tor Lillqvist committed a patch related to this issue. It has been pushed to "libreoffice-6-2": https://git.libreoffice.org/core/+/53be4396bd4708a1197c5a0df5ba6d2341c4ca90%5E%21 tdf#110987: Don't mis-detect .doc files as .dot It will be available in 6.2.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Let's consider this fixed, thanks Tor! Probably should file separate bugs for the Excel and Powerpoint cases from comment #3. Aron? |