| Summary: | FILEOPEN: DOCX: footnote separators missing | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Xisco Faulí <xiscofauli> |
| Component: | Writer | Assignee: | Justin L <jluth> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | jluth, vmiklos, xiscofauli |
| Priority: | medium | Keywords: | bibisected, bisected, filter:docx, regression |
| Version: | 5.3.4.2 release | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=107033 https://bugs.documentfoundation.org/show_bug.cgi?id=68787 |
||
| Whiteboard: | target:6.0.0 target:5.3.6 target:5.4.1 target:7.1.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 103164, 104520 | ||
| Attachments: |
missing footnote separators
Simple footnote.docx: just one footnote is not enough to show the problem. |
||
|
Description
Xisco Faulí
2017-07-04 11:27:42 UTC
Regression introduced by: author Miklos Vajna <vmiklos@collabora.co.uk> 2017-05-03 06:39:31 (GMT) committer Miklos Vajna <vmiklos@collabora.co.uk> 2017-05-03 15:02:19 (GMT) commit e79ef12b7a904f17d4147fa409d055c12b70f952 (patch) tree 183a50f46068c82349441b3ba3ee72847f20f8a6 parent cc0ea8bb251c464d55e831ed7e11a2f3f7371d38 (diff) tdf#107033 DOCX import: fix unexpected missing footnote separator Regression from commit 330b860205c7ba69dd6603f65324d0f89ad9cd5f (fdo#68787 DOCX import: handle when w:separator is missing for footnotes, 2013-09-04), the problem was footnote settings were modified also in case there were no footnotes at all in the document. Make the bug scenario and the original one working at the same time by touching footnote settings only in case there is at least one footnote in the current section. Bisected with bibisect-linux-64-5.4 Adding Cc: to Miklos Vajna attachment 41983 [details] from bug 33072 also misses the separator after e79ef12b7a904f17d4147fa409d055c12b70f952 Created attachment 134483 [details]
Simple footnote.docx: just one footnote is not enough to show the problem.
suggested bug fix at https://gerrit.libreoffice.org/40551 Note: The regression was backported to 5.3.4. Justin Luth committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=6f57c09aadd40009173f8ae3654004dd0cad9fb8 tdf#108944 writerfilter: fix missing footnote separator It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Fixed verified in Version: 6.0.0.0.alpha0+ Build ID: 50799a721c7ddcf9475a1b79984ed64ddd7cdf57 CPU threads: 4; OS: Linux 4.8; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: group Justin Luth committed a patch related to this issue. It has been pushed to "libreoffice-5-3": http://cgit.freedesktop.org/libreoffice/core/commit/?id=234df2fb5901588ccf20cb35cb4c5922aeb89817&h=libreoffice-5-3 tdf#108944 writerfilter: fix missing footnote separator It will be available in 5.3.6. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Justin Luth committed a patch related to this issue. It has been pushed to "libreoffice-5-4": http://cgit.freedesktop.org/libreoffice/core/commit/?id=6d77bfc9b2cf5a30a06a97c69ed814e3a97ed685&h=libreoffice-5-4 tdf#108944 writerfilter: fix missing footnote separator It will be available in 5.4.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. (In reply to Xisco Faulí from comment #6) > Fixed verified in Then Fixed. Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1df6cc318b2559408cf08d7bd43c0298048f9ff7 related tdf#108944 writerfilter: fix another missing ftn separator It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |