Summary: | Set Paragraph Style > "Clear formatting" should be renamed to "Clear all formatting" | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Timur <timur> |
Component: | Writer | Assignee: | Not Assigned <libreoffice-bugs> |
Status: | RESOLVED INVALID | ||
Severity: | trivial | CC: | cno, fitojb, momonasmon, philipz85, vsfoote |
Priority: | medium | ||
Version: | Inherited From OOo | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=70759 https://bugs.documentfoundation.org/show_bug.cgi?id=71233 https://bugs.documentfoundation.org/show_bug.cgi?id=106195 |
||
Whiteboard: | |||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 107318, 107326 |
Description
Timur
2017-03-07 08:22:07 UTC
You are of course referring to the "Formatting" toolbar. There is no "Apply Style" toolbar. That control is a drop list toolbox with tooltip "Set Paragraph Style" [1], through 5.2 release it was "Apply Paragraph Style". The "Clear formatting" action "aClearForm" calls RID_SVXSTR_CLEARFORM [2] and takes its label from its definition [3] However, as Cor pointed out in bug 70759, the action of this control does not clear "All" formatting, just the Paragraph style -- it does not clear any Direct formatting applied and it does not clear other Style types (i.e. Character, Page, Frame, List or Table). Removing "direct" formatting is performed with the .uno:ResetAttributes command associated with the main menu Format -> Clear Direct Formatting command. The RID_SVXSTR_CLEARFORM action will set/reset the *paragraph* style--it should probably be to Default but as in bug 70759 it sets to Text Body. Its labeling controlled from [3] could be changed, but it can not be considered "All" as currently implemented, simply see no need to change it. As to refactoring the RID_SVXSTR_CLEARFORM to affect both paragrah style, other styles and any direct formatting--that would be more than a trivial effort. =-ref-= [1] http://opengrok.libreoffice.org/xref/core/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu#2869 [2] http://opengrok.libreoffice.org/xref/core/svx/source/tbxctrls/tbcontrl.cxx#2202 [3] http://opengrok.libreoffice.org/xref/core/svx/source/tbxctrls/tbcontrl.src#206 |