Summary: | Window is almost empty with GTK 3 and RTL UI | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | خالد حسني <khaled> |
Component: | UI | Assignee: | Caolán McNamara <caolan.mcnamara> |
Status: | VERIFIED FIXED | ||
Severity: | major | CC: | xiscofauli |
Priority: | high | ||
Version: | 5.3.0.1 rc | ||
Hardware: | All | ||
OS: | Linux (All) | ||
Whiteboard: | target:5.4.0 target:5.3.1 target:5.2.6 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 43808, 103182 | ||
Attachments: | Screenshot |
Description
خالد حسني
2017-01-18 15:36:12 UTC
Created attachment 130530 [details]
Screenshot
you can probably lower your resolution out of the auto hidpi range, I find that it works at lower res and doesn't at 4k resolution hidpi, so its something related to that. some 16 bit overflow or something :-) ? Still no idea what is going on, but creating a surface half the size will draw the left half just fine: diff --git a/vcl/unx/gtk3/gtk3gtkframe.cxx b/vcl/unx/gtk3/gtk3gtkframe.cxx index d3a0310245f7..55cbdea37158 100644 --- a/vcl/unx/gtk3/gtk3gtkframe.cxx +++ b/vcl/unx/gtk3/gtk3gtkframe.cxx @@ -1585,7 +1585,7 @@ void GtkSalFrame::AllocateFrame() #endif m_pSurface = gdk_window_create_similar_image_surface(widget_get_window(m_pWindow), CAIRO_FORMAT_ARGB32, - aFrameSize.getX() * scale, + (aFrameSize.getX()/2) * scale, aFrameSize.getY() * scale, scale); #if CAIRO_VERSION >= CAIRO_VERSION_ENCODE(1, 14, 0) But two thirds with draw only the left 1/3 in the middle of the screen! My wild guess is that we are drawing starting from the right edge of the window/surface instead of the left one and all the drawings is now happening outside the window, or something like that. I think I have it Caolán McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=4e9cfc178c47893229f8030bfe73e2b7c5de92c3 Resolves: tdf#105416 blank windows under HiDPI RTL It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. seems to work, hopefully there isn't side effects. backport in gerrit for 5.3 Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-5-3": http://cgit.freedesktop.org/libreoffice/core/commit/?id=c9ab894ae846185a0341656922b0aa1632bfe886&h=libreoffice-5-3 Resolves: tdf#105416 blank windows under HiDPI RTL It will be available in 5.3.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-5-2": http://cgit.freedesktop.org/libreoffice/core/commit/?id=f12d24b25994c22396d768160fe69364f1627459&h=libreoffice-5-2 Resolves: tdf#105416 blank windows under HiDPI RTL It will be available in 5.2.6. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |