Bug 105043

Summary:	Allow user to override font-provided line gap settings
Product:	LibreOffice	Reporter:	Ｖ字龍(Vdragon) <Vdragon.Taiwan>
Component:	Writer	Assignee:	Not Assigned <libreoffice-bugs>
Status:	RESOLVED WONTFIX
Severity:	enhancement	CC:	ilmari.lauhakangas, shanshandehongxing
Priority:	medium
Version:	5.2.3.3 release
Hardware:	All
OS:	All
Whiteboard:
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	109235
Attachments:	Current behavior Expected behavior (This example uses the >2.0 version of the same font, which set the line gap to 0) Font developer's explanation about the line gap changes(in Chinese)

Description Ｖ字龍(Vdragon) 2017-01-02 10:30:51 UTC

Description:
I'm currently using "jf-jinxuan-fresh(jf金萱鮮摘)" v1.00dca proprietary font for a document, however the line gap is too big for non-heading context, according to the font developer the font has OS/2.sTypoLineGap set to 1000 that causes the issue.  Please allow user to manually override the font-provided line gap.

According to Ken Lunde for this kind of issue:

```
The Right Thing(TM) for UIs is to use the OS/2.sTypoAscender and OS/2.sTypoDescender values, ignore the OS/2.sTypoLineGap value, and pick a very modest values, say 200, for the line gap.
```

Steps to Reproduce:
Use a font which OS/2.sTypoLineGap is set to non zero

Actual Results:  
Line gap is set to OS/2.sTypoLineGap and can't be overrided

Expected Results:
Font-provided can be overrided in "Indents & Spacing" tab, and user can specify custom Line Spacing.


Reproducible: Always

User Profile Reset: No

Additional Info:
OS: Ubuntu 16.04 AMD64
DE: Unity
Locale: zh_TW.UTF-8


User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:50.0) Gecko/20100101 Firefox/50.0

Comment 1 Ｖ字龍(Vdragon) 2017-01-02 10:35:25 UTC

Workaround: Line Spacing set to "Fixed" and set to a small value

Comment 2 Ｖ字龍(Vdragon) 2017-01-02 10:37:41 UTC

Created attachment 130086 [details]
Current behavior

Comment 3 Ｖ字龍(Vdragon) 2017-01-02 10:40:18 UTC

Created attachment 130087 [details]
Expected behavior (This example uses the >2.0 version of the same font, which set the line gap to 0)

Comment 4 Ｖ字龍(Vdragon) 2017-01-02 10:55:21 UTC

Created attachment 130089 [details]
Font developer's explanation about the line gap changes(in Chinese)

Comment 5 Ｖ字龍(Vdragon) 2017-01-02 10:59:18 UTC

Updating wording mistake:

```
Expected Results:
Font-provided line gap setting can be overrided in "Indents & Spacing" tab, and user can specify custom Line Spacing.
```

Comment 6 Buovjaga 2017-01-04 15:09:17 UTC

Volga: do you have a similar (or same) feature request?

Comment 7 ⁨خالد حسني⁩ 2017-10-04 11:41:44 UTC

I don’t think we need any more options here, we have enough line spacing options that give the user total control in defining the desired line spacing and overriding the font entirely. Not to mention that this a font bug and like any other bug it should be fixed in its source not worked around in 100s of different places.