Summary: | FILEOPEN: Very slow opening of specific file | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Cor Nouws <cno> |
Component: | Writer | Assignee: | Michael Stahl (allotropia) <michael.stahl> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | aron.budea, bjoern.michaelsen, cno, michael.stahl, xiscofauli |
Priority: | medium | Keywords: | bibisected, bisected, perf, regression |
Version: | 5.3.0.3 release | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=99817 | ||
Whiteboard: | target:5.3.3 target:5.3.2 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 104450 |
Description
Cor Nouws
2016-12-06 20:53:25 UTC
Indeed, there seems to be a performance regression: In Version: 5.4.0.0.alpha0+ Build ID: 18b3138a7ac4da823e41640bed8a4707029b8fb0 CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: group a roundtrip takes: real 2m28.973s user 2m22.452s sys 0m3.040s while in Version: 4.5.0.0.alpha0+ Build ID: 2851ce5afd0f37764cbbc2c2a9a63c7adc844311 Locale: ca_ES real 1m12.332s user 1m9.364s sys 0m0.244s Bibisected using repo bibisect-win-5.3. Good load times: ~15-20s. Bad load times: ~60-70s. 83f9106e7ba780211d605140239bcf87db7aaa46 is the first bad commit commit 83f9106e7ba780211d605140239bcf87db7aaa46 Author: Norbert Thiebaud <nthiebaud@gmail.com> Date: Wed Sep 28 02:50:07 2016 -0700 source bcc3509cdbffef6a3f371434161efbfc4fbd8e5c # bad: [a374222bc87bd9e75ea2f1ca45d189932a1967f8] source aa09fd58bd499a2a2c3a32c5f613892bad54076c # good: [defb73f1c6e2a66dbd21ba89e684f57427e8bc4b] source 5b168b3fa568e48e795234dc5fa454bf24c9805e git bisect start 'a374222bc87bd9e75ea2f1ca45d189932a1967f8' 'oldest' # good: [0b4408f0568ad1da0797543c0ee2955c386267ee] source 8f7886c742cae5e012e52029c20925aa7b0fb6ea git bisect good 0b4408f0568ad1da0797543c0ee2955c386267ee # bad: [f8b90d89a8a858c3e0ce171f82ecb20b3ea80098] source 75239b77139434db9be5e0e7e133e3661c5404b0 git bisect bad f8b90d89a8a858c3e0ce171f82ecb20b3ea80098 # bad: [ec81563f3383907aa8001ae1bf3967dc962838e8] source def490468df794166ce7bba1ec2d2feb410278ab git bisect bad ec81563f3383907aa8001ae1bf3967dc962838e8 # good: [83364675ac1ab181282be3666dd31770f8f4c0e0] source 983d1c4d4c6f69c6b4e2d2fa88d408e35ed6b220 git bisect good 83364675ac1ab181282be3666dd31770f8f4c0e0 # good: [620e218890c05b2c52951cddbe35ac4cc69bf80e] source 751689283c9f3010f7978b6576b25ffc579202ef git bisect good 620e218890c05b2c52951cddbe35ac4cc69bf80e # good: [f76c15f1254c85aa6b8ae9e2fa0cb3b009bb6650] source da2e1ea7d4a919a13caf159d1afce13843f7a621 git bisect good f76c15f1254c85aa6b8ae9e2fa0cb3b009bb6650 # bad: [843f7c7e2c537098206b152c108ab014c6f7846d] source c688bc302683338853c4ae485c09a34d871ecdb1 git bisect bad 843f7c7e2c537098206b152c108ab014c6f7846d # bad: [83f9106e7ba780211d605140239bcf87db7aaa46] source bcc3509cdbffef6a3f371434161efbfc4fbd8e5c git bisect bad 83f9106e7ba780211d605140239bcf87db7aaa46 # good: [ea80e74f201d8b93af9c4ee7a177d1ed010eaf56] source f20996450e409406f4f55f9eb7ca9bfe1e455c35 git bisect good ea80e74f201d8b93af9c4ee7a177d1ed010eaf56 # good: [21be4341142d5af86b6dc3c869a3cf1a09d38ba4] source 43e9abd29cc3a9246a3d2789024c6c252974c9e3 git bisect good 21be4341142d5af86b6dc3c869a3cf1a09d38ba4 # good: [cfc9372af3afb547d837034bd563bc1fedd408c2] source 99d2240ab618b4877af99234e8897315c00ad01b git bisect good cfc9372af3afb547d837034bd563bc1fedd408c2 # good: [ac8709cf6b077412f4c14896cb3f6bf86dfc288a] source 6c673a29947924148b9550517b98d8953680a2ca git bisect good ac8709cf6b077412f4c14896cb3f6bf86dfc288a # good: [0bbe9fa6a9edc80192d294128269481bb69817e1] source 39ac3aed06c65184e4c387234d045aee8f684e04 git bisect good 0bbe9fa6a9edc80192d294128269481bb69817e1 # first bad commit: [83f9106e7ba780211d605140239bcf87db7aaa46] source bcc3509cdbffef6a3f371434161efbfc4fbd8e5c Bibisect points to the first commit referenced below. Most of it is debug code, so it's probably the pass-by-value parameter of lcl_DebugMarks? Additionally, it's fixed in master by the second commit below (verified using repo bibisect-win-5.4). Adding Cc: to Michael Stahl, please backport the fixing commit. https://cgit.freedesktop.org/libreoffice/core/commit/?id=bcc3509cdbffef6a3f371434161efbfc4fbd8e5c author Michael Stahl <mstahl@redhat.com> 2016-09-27 13:16:49 (GMT) committer Michael Stahl <mstahl@redhat.com> 2016-09-28 09:03:56 (GMT) "sw: make the debug code in docbm.cxx usable" https://cgit.freedesktop.org/libreoffice/core/commit/?id=f6596a35c2d9a8c365bb78e1256a2def57ee1a36 author Michael Stahl <mstahl@redhat.com> 2017-02-03 15:48:02 (GMT) committer Michael Stahl <mstahl@redhat.com> 2017-02-03 17:20:07 (GMT) "sw: make lcl_DebugMarks output more readable, pos. at the start" oops, that was surprising. backported https://gerrit.libreoffice.org/#/c/35492/ Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-5-3": http://cgit.freedesktop.org/libreoffice/core/commit/?id=4c7775247fbbf38cd397fd7649bf10810f27a0b4&h=libreoffice-5-3 tdf#104447 sw: make lcl_DebugMarks output more readable, pos. at the start It will be available in 5.3.3. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-5-3-2": http://cgit.freedesktop.org/libreoffice/core/commit/?id=db5bde754ed1c8ab6ae1d9bf346cf954de706bb1&h=libreoffice-5-3-2 tdf#104447 sw: make lcl_DebugMarks output more readable, pos. at the start It will be available in 5.3.2. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |