Summary: | track changes - show changes is always marked as enabled, even after disabling | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Justin L <jluth> |
Component: | Writer | Assignee: | Justin L <jluth> |
Status: | VERIFIED FIXED | ||
Severity: | major | CC: | jluth, noelgrandin, xiscofauli |
Priority: | high | Keywords: | bibisected, bisected, regression |
Version: | 5.3.0.0.alpha0+ | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | target:5.3.0 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 83946, 89991 |
Description
Justin L
2016-11-19 04:22:33 UTC
Moving it to NEW as the problematic commit has been identified Justin Luth committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=bbe19c1312500c63748583eb2e64f5cd1190942c tdf#104023 - fix wrong boolean logic for RedlineFlags It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Let me note that probably the same issue is present in LO-Fresh 5.2.3 (Arch Linux). In "Edit" menu there is only a (non-functional) check-box menu entry "Track changes", (not) working as described in the bug report; there is no sub-menu with relevant entries, as in LO-Still 5.1.6. So if Fresh is going to see further releases before 5.3, this should be fixed there as well. (In reply to Nikos Platis from comment #3) > Let me note that probably the same issue is present in LO-Fresh 5.2.3 (Arch > Linux). Hi Nikos. I just checked and "convert nsRedlineMode_t to typed_flags" was never back-ported to LO 5.2. > In "Edit" menu there is only a (non-functional) check-box menu entry > "Track changes", (not) working as described in the bug report; there is no > sub-menu with relevant entries, as in LO-Still 5.1.6. Are you refering to using Writer? In Ubuntu and LO 5.2.3.2 I do have a submenu for Edit - Track Changes (and no checkbox for Edit - Track Changes). The same is true for the libreoffice-5-2 development branch. So I cannot replicate your report. > So if Fresh is going to see further releases before 5.3, this should be > fixed there as well. Probably it will be best to create a new bug report if you can consistently replicate the problem - since it will be a different one than was fixed by this bug-report. In 5.3, there is also a VIEW - Track Changes which is a simple checkbox. It is identical to EDIT - Track Changes - Show. Perhaps that is what Nikos was looking at. |