Summary: | Formula NETWORKDAYS do not use OASIS order for Work days (4th parameter) | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | pierre-yves samyn <pierre-yves.samyn> |
Component: | Calc | Assignee: | Winfried Donkers <winfrieddonkers> |
Status: | CLOSED FIXED | ||
Severity: | normal | CC: | gerard.fargeot, miguelangelrv, raal, winfrieddonkers, xiscofauli |
Priority: | medium | ||
Version: | 5.1.3.2 release | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | target:5.3.0 target:5.2.0.1 target:5.1.5 | ||
Crash report or crash signature: | Regression By: | ||
Attachments: | NETWORKDAYS.ods |
Description
pierre-yves samyn
2016-06-12 12:40:47 UTC
Reproducible. Win10x64 Version: 5.1.4.1 (x64) Build ID: a4d48e4ff0e9f93e78b6356ca7b0b6303e360356 CPU Threads: 4; OS Version: Windows 6.19; UI Render: GL; Changing the locale for cells or LibreOffice to English US doesn't help. It is the world upside down : Excel pushing ISO standard and ODF (OASIS) american standard... For NETWORDAYS.INTL, Excel help says : "Weekend string values are seven characters long and each character in the string represents a day of the week, starting with Monday. 1 represents a non-workday and 0 represents a workday. Only the characters 1 and 0 are permitted in the string. Using 1111111 will always return 0. For example, 0000011 would result in a weekend that is Saturday and Sunday." Should we provide a NETWORKDAYS function with week beginning on Sunday and NETWORKDAYS.INTL with week starting on Monday ? Confusing... Hi (In reply to GerardF from comment #2) > It is the world upside down : > Excel pushing ISO standard and ODF (OASIS) american standard... :) > Should we provide a NETWORKDAYS function with week beginning on Sunday and > NETWORKDAYS.INTL with week starting on Monday ? The current functionning is ok for me (monday, tuesday... order). My concern is: I started documentation. Should I wait, is this a bug, and it will be modified, or it is deliberate (for consistency with other functions as you marked). The change was not documented in the release notes but refers to OASIS, we can not know... Regards Pierre-Yves As NETWORKDAYS should fully comply with ODF1.2 and currently it doesn't, I will fix this. Winfried Donkers committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=d81fa4eb3a8960c1a1280fdd07bafa29de8290d2 tdf#100342 fix order of weekdays in NETWORKDAYS It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Winfried Donkers committed a patch related to this issue. It has been pushed to "libreoffice-5-2": http://cgit.freedesktop.org/libreoffice/core/commit/?id=2c9f14bd4bb764d61ca672bd1d64af2f28fb5dd6&h=libreoffice-5-2 tdf#100342 fix order of weekdays in NETWORKDAYS It will be available in 5.2.0.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Winfried Donkers committed a patch related to this issue. It has been pushed to "libreoffice-5-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=641dfede9749dcc054b185bd72b227c0a1c093df&h=libreoffice-5-1 tdf#100342 fix order of weekdays in NETWORKDAYS It will be available in 5.1.5. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Thanks for fixing. Verified. Hi Verified on windows 7/64 & Version: 5.3.0.0.alpha1+ Build ID: 8a796410ec8f440b4163b15b928347c499da7a8f CPU Threads: 2; OS Version: Windows 6.1; UI Render: default; TinderBox: Win-x86@42, Branch:master, Time: 2016-10-20_23:07:21 Locale: fr-FR (fr_FR); Calc: group Thank you Regards Pierre-Yves This is already covered in sc/qa/unit/data/functions/date_time/fods/networkdays.fods |