Attachment 188448 Details for Bug 156361 – Patch that disables Skia alpha blending and falls through to the non-Skia slow path

[patch] Patch that disables Skia alpha blending and falls through to the non-Skia slow path

skip-skia-alpha-blending.diff (text/plain), 1.38 KB, created by Patrick Luby (volunteer) on 2023-07-18 21:15:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Patrick Luby (volunteer)

Created: 2023-07-18 21:15:48 UTC

Size: 1.38 KB

patch

obsolete

>diff --git a/vcl/source/outdev/bitmap.cxx b/vcl/source/outdev/bitmap.cxx
>index 612ea5dc605d..301eeb169158 100644
>--- a/vcl/source/outdev/bitmap.cxx
>+++ b/vcl/source/outdev/bitmap.cxx
>@@ -341,6 +341,7 @@ void OutputDevice::DrawDeviceAlphaBitmap( const Bitmap& rBmp, const AlphaMask& r
>         // try to blend the alpha bitmap with the alpha virtual device
>         if (mpAlphaVDev)
>         {
>+#if 0
>             Bitmap aAlphaBitmap( mpAlphaVDev->GetBitmap( aRelPt, aOutSz ) );
>             if (SalBitmap* pSalAlphaBmp2 = aAlphaBitmap.ImplGetSalBitmap().get())
>             {
>@@ -350,6 +351,7 @@ void OutputDevice::DrawDeviceAlphaBitmap( const Bitmap& rBmp, const AlphaMask& r
>                     return;
>                 }
>             }
>+#endif
>         }
>         else
>         {
>@@ -357,12 +359,14 @@ void OutputDevice::DrawDeviceAlphaBitmap( const Bitmap& rBmp, const AlphaMask& r
>                 return;
>         }
> 
>+#if 0
>         // we need to make sure Skia never reaches this slow code path
>         // (but do not fail in no-op cases)
>         assert(!SkiaHelper::isVCLSkiaEnabled()
>             || tools::Rectangle(Point(), rBmp.GetSizePixel())
>                 .Intersection(tools::Rectangle(rSrcPtPixel, rSrcSizePixel)).IsEmpty()
>             || mpAlphaVDev->LogicToPixel(mpAlphaVDev->GetOutputSizePixel()).IsEmpty());
>+#endif
>     }
> 
>     tools::Rectangle aBmpRect(Point(), rBmp.GetSizePixel());

Actions: View

Attachments on bug 156361: 188447 | 188448 | 188498 | 188548