Attachment 40363 Details for Bug 31494 – probably also good to do

[patch] probably also good to do

configmgr.dontspawn.if.nochanges.patch (text/plain), 1.15 KB, created by Caolán McNamara on 2010-11-18 02:11:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Caolán McNamara

Created: 2010-11-18 02:11:09 UTC

Size: 1.15 KB

patch

obsolete

>diff --git a/configmgr/source/components.cxx b/configmgr/source/components.cxx
>index 2e07320..ba51d6a 100644
>--- a/configmgr/source/components.cxx
>+++ b/configmgr/source/components.cxx
>@@ -304,7 +304,17 @@ void Components::addModification(Path const & path) {
>     data_.modifications.add(path);
> }
> 
>+bool Components::hasModifications() const
>+{
>+    return data_.modifications.getRoot().children.begin() !=
>+        data_.modifications.getRoot().children.end();
>+}
>+
> void Components::writeModifications() {
>+
>+    if (!hasModifications())
>+        return;
>+
>     if (!writeThread_.is()) {
>         writeThread_ = new WriteThread(
>             &writeThread_, *this, getModificationFileUrl(), data_);
>diff --git a/configmgr/source/components.hxx b/configmgr/source/components.hxx
>index 2d0843b..906523e 100644
>--- a/configmgr/source/components.hxx
>+++ b/configmgr/source/components.hxx
>@@ -95,6 +95,8 @@ public:
> 
>     void writeModifications();
> 
>+    bool hasModifications() const;
>+
>     void flushModifications();
>         // must be called with configmgr::lock unaquired; must be called before
>         // shutdown if writeModifications has ever been called (probably

Actions: View

Attachments on bug 31494: 40362 | 40363 | 40471