Attachment 168224 Details for Bug 130275 – a patch which works but need expert's revision

[patch] a patch which works but need expert's revision

0001-tdf-130275-Fields-dialog-is-too-tall.patch (text/plain), 4.40 KB, created by Kevin Suo on 2020-12-16 11:59:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kevin Suo

Created: 2020-12-16 11:59:05 UTC

Size: 4.40 KB

patch

obsolete

>From cfc7e97e35cc5840c0e4172eeb0487549f6d3a0a Mon Sep 17 00:00:00 2001
>From: Kevin Suo <suokunlong@126.com>
>Date: Wed, 16 Dec 2020 19:49:27 +0800
>Subject: [PATCH] tdf#130275: Fields dialog is too tall
>
>...which makes the OK/Cancel buttons invisible under small displays.
>
>Change-Id: If5263e587bfc5042d9fa9da36d687b5272c3c379
>---
> sw/source/ui/fldui/flddb.cxx   | 2 +-
> sw/source/ui/fldui/flddinf.cxx | 2 +-
> sw/source/ui/fldui/flddok.cxx  | 2 +-
> sw/source/ui/fldui/fldfunc.cxx | 2 +-
> sw/source/ui/fldui/fldref.cxx  | 2 +-
> sw/source/ui/fldui/fldvar.cxx  | 2 +-
> 6 files changed, 6 insertions(+), 6 deletions(-)
>
>diff --git a/sw/source/ui/fldui/flddb.cxx b/sw/source/ui/fldui/flddb.cxx
>index 99a7d5f05b3b..2c155d0e45da 100644
>--- a/sw/source/ui/fldui/flddb.cxx
>+++ b/sw/source/ui/fldui/flddb.cxx
>@@ -52,7 +52,7 @@ SwFieldDBPage::SwFieldDBPage(weld::Container* pPage, weld::DialogController* pCo
>     m_xFormatLB->make_sorted();
> 
>     auto nWidth = m_xTypeLB->get_approximate_digit_width() * FIELD_COLUMN_WIDTH;
>-    auto nHeight = m_xTypeLB->get_height_rows(14);
>+    auto nHeight = m_xTypeLB->get_height_rows(1);
>     m_xTypeLB->set_size_request(nWidth, nHeight);
>     m_xDatabaseTLB->set_size_request(nWidth*2, nHeight);
> 
>diff --git a/sw/source/ui/fldui/flddinf.cxx b/sw/source/ui/fldui/flddinf.cxx
>index 9bb8e08cf737..56db4ffffd4e 100644
>--- a/sw/source/ui/fldui/flddinf.cxx
>+++ b/sw/source/ui/fldui/flddinf.cxx
>@@ -63,7 +63,7 @@ SwFieldDokInfPage::SwFieldDokInfPage(weld::Container* pPage, weld::DialogControl
>     FillFieldSelect(*m_xSelectionLB);
> 
>     auto nWidth = m_xTypeTLB->get_approximate_digit_width() * FIELD_COLUMN_WIDTH;
>-    auto nHeight = m_xTypeTLB->get_height_rows(20);
>+    auto nHeight = m_xTypeTLB->get_height_rows(1);
>     m_xTypeTLB->set_size_request(nWidth, nHeight);
>     m_xFormatLB->get_widget().set_size_request(nWidth, nHeight);
>     m_xSelectionLB->set_size_request(nWidth, nHeight);
>diff --git a/sw/source/ui/fldui/flddok.cxx b/sw/source/ui/fldui/flddok.cxx
>index 5c6bc57e70aa..ad0ad2d2d09f 100644
>--- a/sw/source/ui/fldui/flddok.cxx
>+++ b/sw/source/ui/fldui/flddok.cxx
>@@ -53,7 +53,7 @@ SwFieldDokPage::SwFieldDokPage(weld::Container* pPage, weld::DialogController* p
>     m_xFormatLB->make_sorted();
> 
>     auto nWidth = m_xTypeLB->get_approximate_digit_width() * FIELD_COLUMN_WIDTH;
>-    auto nHeight = m_xTypeLB->get_height_rows(20);
>+    auto nHeight = m_xTypeLB->get_height_rows(1);
> 
>     m_xTypeLB->set_size_request(nWidth, nHeight);
>     m_xSelectionLB->set_size_request(nWidth, nHeight);
>diff --git a/sw/source/ui/fldui/fldfunc.cxx b/sw/source/ui/fldui/fldfunc.cxx
>index c2e6cbef2572..aa8f2e172bc5 100644
>--- a/sw/source/ui/fldui/fldfunc.cxx
>+++ b/sw/source/ui/fldui/fldfunc.cxx
>@@ -68,7 +68,7 @@ SwFieldFuncPage::SwFieldFuncPage(weld::Container* pPage, weld::DialogController*
>                                      m_xListItemsLB->get_height_rows(5));
> 
>     auto nWidth = m_xTypeLB->get_approximate_digit_width() * FIELD_COLUMN_WIDTH;
>-    auto nHeight = m_xTypeLB->get_height_rows(20);
>+    auto nHeight = m_xTypeLB->get_height_rows(1);
>     m_xTypeLB->set_size_request(nWidth, nHeight);
>     m_xFormatLB->set_size_request(nWidth, nHeight);
> 
>diff --git a/sw/source/ui/fldui/fldref.cxx b/sw/source/ui/fldui/fldref.cxx
>index 6c92d6f4d07a..6609f87333ca 100644
>--- a/sw/source/ui/fldui/fldref.cxx
>+++ b/sw/source/ui/fldui/fldref.cxx
>@@ -85,7 +85,7 @@ SwFieldRefPage::SwFieldRefPage(weld::Container* pPage, weld::DialogController* p
>     m_xTypeLB->set_size_request(nWidth, nHeight);
>     m_xFormatLB->set_size_request(nWidth, nHeight);
>     m_xSelection->set_size_request(nWidth * 2, nHeight);
>-    nHeight = m_xTypeLB->get_height_rows(20);
>+    nHeight = m_xTypeLB->get_height_rows(1);
>     m_xSelectionToolTipLB->set_size_request(nHeight, nWidth*2);
> 
>     m_xTypeLB->clear();
>diff --git a/sw/source/ui/fldui/fldvar.cxx b/sw/source/ui/fldui/fldvar.cxx
>index 7697e4413da7..b9ece8a520a9 100644
>--- a/sw/source/ui/fldui/fldvar.cxx
>+++ b/sw/source/ui/fldui/fldvar.cxx
>@@ -64,7 +64,7 @@ SwFieldVarPage::SwFieldVarPage(weld::Container* pPage, weld::DialogController* p
>     FillFieldSelect(*m_xFormatLB);
> 
>     auto nWidth = m_xTypeLB->get_approximate_digit_width() * FIELD_COLUMN_WIDTH;
>-    auto nHeight = m_xTypeLB->get_height_rows(20);
>+    auto nHeight = m_xTypeLB->get_height_rows(1);
>     m_xTypeLB->set_size_request(nWidth, nHeight);
>     m_xSelectionLB->set_size_request(nWidth, nHeight);
>     m_xFormatLB->set_size_request(nWidth, nHeight/2);
>-- 
>2.26.2
>

Actions: View

Attachments on bug 130275: 157519 | 168177 | 168224 | 168225 | 168292 | 168297 | 168298 | 168587