Bug 90792

Summary: Enable toolbar code to load HiDPI bitmaps
Product: LibreOffice Reporter: Keith Curtis <keithcu>
Component: UIAssignee: Not Assigned <libreoffice-bugs>
Status: RESOLVED WORKSFORME    
Severity: normal CC: iandol, keithcu, libreoffice-ux-advise, mentoring, xiscofauli
Priority: medium Keywords: difficultyInteresting, easyHack, skillCpp, topicUI
Version: 4.2.3.3 release   
Hardware: Other   
OS: Linux (All)   
Whiteboard:
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 90796, 103239    

Description Keith Curtis 2015-04-22 21:40:03 UTC
People are working on HiDPI toolbar bitmaps, but the LibreOffice code still needs to support to loading them.
 
The current code just doubles all the bitmaps: http://opengrok.libreoffice.org/xref/core/vcl/source/window/toolbox2.cxx#1112

This is a nice little hack that can stay around as long as we still have some themes without better bitmaps, but one day someone needs to write a bit of code that fixes (some of) the callers of this routine, and make them load larger bitmaps if they exist for a theme.

One open issue is whether it worth it using the SVG format.

I believe this is an interesting Easy Hack that could make a nice visual improvement on these pretty screens. For now, it would probably only apply to Linux and Windows, and somewhat different code would be needed for the Mac.
Comment 1 Robinson Tryon (qubit) 2015-12-14 05:00:14 UTC Comment hidden (obsolete)
Comment 2 Robinson Tryon (qubit) 2016-02-18 14:51:23 UTC Comment hidden (obsolete)
Comment 3 Keith Curtis 2016-12-12 06:14:05 UTC
I saw this was fixed in 5.3.