Bug 160984

Summary: FILEOPEN DOCX: endnote is on separate page, not inline
Product: LibreOffice Reporter: Miklos Vajna <vmiklos>
Component: WriterAssignee: Miklos Vajna <vmiklos>
Status: RESOLVED FIXED    
Severity: normal CC: aron.budea, buzea.bogdan, Tex2002ans+LibreOffice
Priority: medium    
Version: unspecified   
Hardware: All   
OS: All   
See Also: https://bugs.documentfoundation.org/show_bug.cgi?id=161083
Whiteboard: target:24.8.0
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 109195    
Attachments: Reproducer document
WIP patch
Demo of bad vertical position of endnote content (Word is red, Writer is painted on top of it)
Demo of bad vertical position of endnote separator
Demo of bad length of endnote separator
Endnote continuation separator lengh mismatch

Description Miklos Vajna 2024-05-08 06:39:28 UTC
Created attachment 194020 [details]
Reproducer document

This may be the same as bug 58521, I'm not yet sure.

Steps to reproduce:

1) Open the attached DOCX file.
2) Look at the order of foot/endnotes.

Expected result: "This is an endnote", then "This is a footnote"

Actual result: "This is a footnote", then "This is an endnote" on a separate page.
Comment 1 Commit Notification 2024-05-08 10:49:41 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/90f19126fa405a0632eae4ee8525b66bbce12625

tdf#160984 sw continuous endnotes: introduce an endnote section

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 2 Commit Notification 2024-05-09 07:35:30 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/8bae684c93bd23bbe98707ba9cf75d1a39427131

tdf#160984 sw continuous endnotes: add a way to find the endnote section start

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Miklos Vajna 2024-05-09 12:48:23 UTC
Created attachment 194053 [details]
WIP patch

A snapshot of local changes that I have to fix the bugdoc, but not yet pushing as I'm aware of unwanted side effects.
Comment 4 Commit Notification 2024-05-10 07:06:01 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ab3416cad1dd4e706432f9b1a3592cec823c76b0

tdf#160984 sw continuous endnotes: fix testContinuousEndnotesMoveBackwards

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2024-05-13 10:15:28 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/9c7acbc937b3b341c10187b837e09cc20399f04e

tdf#160984 sw continuous endnotes: fix CppunitTest_sw_layoutwriter3

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2024-05-14 10:09:33 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6885dcd7ec7b82a946d8344bfc27a3e88eecc44a

tdf#160984 sw continuous endnotes: switch to a section-based layout

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2024-05-16 08:14:45 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/d74fb6b571304b41c13b7a6dcdd2b853bfca7210

tdf#160984 sw continuous endnotes, DOC import: enable this unconditionally

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2024-05-21 08:43:27 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1ae5ea3f78cca11ba18f2dd1a06f875263336a3b

tdf#160984 sw continuous endnotes: enable DOCX import

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Miklos Vajna 2024-05-21 09:07:09 UTC
The inline / continuous endnote part is now done, I think. The position of the endnote separator is still bad, I'll look at that.
Comment 10 Miklos Vajna 2024-05-22 07:59:04 UTC
Created attachment 194265 [details]
Demo of bad vertical position of endnote content (Word is red, Writer is painted on top of it)

Demo of the current bad vertical position of endnote content. Red is meant to disappear as fixes are done.
Comment 11 Commit Notification 2024-05-22 15:50:18 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/d1ddd136a1b0e452492464d58715eaec144fd811

tdf#160984 sw continuous endnotes: fix the endnote container's top margin

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Miklos Vajna 2024-05-23 12:45:30 UTC
Created attachment 194306 [details]
Demo of bad vertical position of endnote separator
Comment 13 Commit Notification 2024-05-23 19:01:40 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f1d0b4e34a1f467e9f54baa7ac31ca28fdae3efb

tdf#160984 sw continuous endnotes: fix the endnote separator position

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 14 Miklos Vajna 2024-05-24 06:46:12 UTC
Created attachment 194324 [details]
Demo of bad length of endnote separator

Length is bad, then the foot/endnote separator will be good, I think.
Comment 15 Commit Notification 2024-05-24 10:36:29 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/755f3bebd96ec7ae43b1dcf247f907b9c15c1995

tdf#160984 sw continuous endnotes: fix the endnote separator length

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 16 Commit Notification 2024-05-27 09:28:18 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/3f2d0414686a8f9a042413c47c4c8ffa5d61f436

tdf#160984 sw continuous endnotes: fix crash on loading forum-mso-en-7731.docx

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 17 Commit Notification 2024-05-28 15:14:21 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2d2dd56e0b2dc708f1f758d7fc9a1263ff09b83c

tdf#160984 sw continuous endnotes: DOCX: import <w:endnotePr> pos == sectEnd

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 18 Commit Notification 2024-05-29 18:11:52 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/566c7017a84e3d573de85a6d986b81d3f59de0fa

tdf#160984 sw continuous endnotes: DOCX: export of <w:endnotePr> pos == sectEnd

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 19 Miklos Vajna 2024-05-30 11:49:27 UTC
Created attachment 194455 [details]
Endnote continuation separator lengh mismatch

One more misrender: the endnote continuation separator in Word is longer, see the attached visual diff (Word is red, Writer is rendered on top of it).
Comment 20 Commit Notification 2024-05-31 15:01:50 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6450159e0e7c5fac9c998087e99f3fec602ff84d

tdf#160984 sw continuous endnotes: fix the endnote continuation separator len

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 21 Commit Notification 2024-05-31 20:00:30 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/8f3e11dc9a4b3fd9ad1985d88b241df7bcb66fec

tdf#160984 sw continuous endnotes: hide not functional UI in this mode

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 22 Commit Notification 2024-06-03 16:35:00 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b79b50c8f06a5c977451995b2d632e5738d7d335

tdf#160984 sw continuous endnotes: add enable/disable option UI

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.