Bug 160908

Summary:	"Edit cell background highlight"
Product:	LibreOffice	Reporter:	Olivier Hallot <olivier.hallot>
Component:	Calc	Assignee:	Sahil Gautam <printfdebugging>
Status:	RESOLVED FIXED
Severity:	normal	CC:	buzea.bogdan, heiko.tietze, printfdebugging
Priority:	medium
Version:	unspecified
Hardware:	All
OS:	All
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=63374
Whiteboard:	target:24.8.0
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	112128

Description Olivier Hallot 2024-05-02 12:15:45 UTC

With respect to bug#63374, please improve text for the checkbox and the related extended tip.

Currently:

"Edit cell background highlight" can be changed to 

"Highlight cell background when in edit mode" 
or 
"Highlight cell background when editing cell"

The extended tip is currently:

"Mark the Edit cell background highlighting checkbox to show cell frame background color as the edit cell background."

It can be simplified to 

"Mark this box to show highlighted background when editing the cell"

UI file to touch is 

sc/uiconfig/scalc/ui/tpviewpage.ui

Comment 1 Heiko Tietze 2024-05-03 07:09:31 UTC

(In reply to Olivier Hallot from comment #0)
> "Highlight cell background when in edit mode" 
Way too long for the UI.

How about "Edit highlight" with a long tooltip?

Alternatively we can remove the feature since the OP rejected this as a solution for bug 63374.

Comment 2 Sahil Gautam 2024-05-03 14:32:16 UTC

I made some changes to match what is asked by the OP in tdf#63374. Should I accommodate these label related changes in that patch?

Comment 3 Heiko Tietze 2024-05-06 08:47:25 UTC

(In reply to Printf Debugging from comment #2)
> I made some changes to match what is asked by the OP in tdf#63374. Should I
> accommodate these label related changes in that patch?
If you were a tailor you could hit seven at one blow :-).

Just add both tickets in the summary like "Resolves tdf#123 and tdf#456: Lorem ipsum".

Comment 4 Heiko Tietze 2024-05-07 07:50:27 UTC

(In reply to Heiko Tietze from comment #1)
> How about "Edit highlight" with a long tooltip?
This is going into production.

Comment 5 Commit Notification 2024-05-13 11:24:40 UTC

Printf Debugging committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/3eb427b31e624af9b2fe2bd68fee859d3d76a661

Resolves tdf#63374 and tdf#160908

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.