Bug 160680

Summary: GIF looks worse in HiDPI mode
Product: LibreOffice Reporter: Aron Budea <aron.budea>
Component: graphics stackAssignee: Not Assigned <libreoffice-bugs>
Status: UNCONFIRMED ---    
Severity: normal CC: caolan.mcnamara, gerald, noelgrandin, telesto
Priority: medium Keywords: bibisected, bisected
Version: 7.2.0.4 release   
Hardware: All   
OS: All   
See Also: https://bugs.documentfoundation.org/show_bug.cgi?id=99508
https://bugs.documentfoundation.org/show_bug.cgi?id=153162
Whiteboard: QA:needsComment
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 90796, 108438    
Attachments: Screenshot with GIF in HiDPI mode (bad)
Screenshot with GIF in regular mode (good)

Description Aron Budea 2024-04-15 20:06:17 UTC
Created attachment 193696 [details]
Screenshot with GIF in HiDPI mode (bad)

Open attachment 193476 [details] from bug 153162, and play the slideshow.

=> The animated GIF on the 3rd page looks worse if the display is HiDPI (4K with 200% scaling) than with 100% scaling.

Observed using LO 24.8.0.0.alpha0+ (f3d0a184c4da57907a1fcf1ed784340be7d974d6) / Ubuntu.
Comment 1 Aron Budea 2024-04-15 20:07:42 UTC
Created attachment 193697 [details]
Screenshot with GIF in regular mode (good)
Comment 2 Aron Budea 2024-04-21 03:31:01 UTC
This is somewhat of a regression, because before the following commit in 5.4 (and its backports to 5.3/5.2), the GIF is shown fine, though only a quarter of the LO window is shown (again, this is with 4K and 200% scaling).

https://cgit.freedesktop.org/libreoffice/core/commit/?id=d9a6e0023c9a192850b9db00f8120fbcc4256ec9
author		Caolán McNamara <caolanm@redhat.com>	2016-11-22 15:35:16 +0000
committer	Tomaž Vajngerl <quikee@gmail.com>	2016-11-23 22:40:58 +0000

"Resolves: tdf#99508 ensure sufficient size for hidpi backing surface"


In addition, the GIF looks fine when LibreOffice is run with gen VCL plugin, but LO crashes out after the slideshow, with the following on the console:

========

X-Error: BadDrawable (invalid Pixmap or Window parameter)
	Major opcode: 62 (X_CopyArea)
	Resource ID:  0x88006b6
	Serial No:    28385 (28385)
Unspecified Application Error

========

It's probably unrelated to the reported issue, and started between the following commits on 5.3 (between those LO fails to start with gen VCL plugin):
https://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=5bb5463efefc4d65e3434b37618cb74a1fe2a598..36888dc9607b6ce1f98a0a7fcd1069ded091aec1
Comment 3 Aron Budea 2024-04-21 04:43:36 UTC
Actually, this got resolved via the following commit in 6.0:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=d148340babf6c973f7d463909d7a51e16c953248
author		Caolán McNamara <caolanm@redhat.com>	2017-07-26 14:37:40 +0100
committer	Caolán McNamara <caolanm@redhat.com>	2017-07-26 17:58:47 +0200

"Resolves: tdf#104141 CAIRO_FORMAT_A1 vs N1BitLsbPal"

...and got reintroduced in 7.2 via:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=b153d147c9d813f78dd551fc186c261f52c929a1
author		Noel Grandin <noel.grandin@collabora.co.uk>	2021-04-28 15:27:14 +0200
committer	Noel Grandin <noel.grandin@collabora.co.uk>	2021-04-29 08:40:56 +0200

"remove support for BITMASK in vcl backends"