Summary: | Navigator empty after inserting formula OLE object | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Stéphane Guillou (stragu) <stephane.guillou> |
Component: | Draw | Assignee: | Not Assigned <libreoffice-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | raykowj |
Priority: | medium | Keywords: | bibisected, bisected, regression |
Version: | 7.5.5.2 release | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=155393 https://bugs.documentfoundation.org/show_bug.cgi?id=160190 |
||
Whiteboard: | target:24.8.0 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 103030 | ||
Attachments: | sample ODG |
Description
Stéphane Guillou (stragu)
2024-03-08 06:23:04 UTC
Hi Stéphane, Here's a one liner patch: https://gerrit.libreoffice.org/c/core/+/164607 While investing the cause of this bug I noticed that previous to the 'tdf#155393 SdNavigator: Enhancement to navigate in Notes view' patch, while the Navigator tree is as expected after a 'Formula Object' or 'OLE Object...' insert, Navigator tracking of the selected objects/shapes ceases to work until one of a few different things that cause it to start working are done, such as, inserting something other than a formula or OLE object or closing and reopening the Navigator. Thanks Jim, the patch works. (In reply to Jim Raykowski from comment #1) > While investing the cause of this bug I noticed that previous to the > 'tdf#155393 SdNavigator: Enhancement to navigate in Notes view' patch, while > the Navigator tree is as expected after a 'Formula Object' or 'OLE > Object...' insert, Navigator tracking of the selected objects/shapes ceases > to work until one of a few different things that cause it to start working > are done, such as, inserting something other than a formula or OLE object or > closing and reopening the Navigator. I can reproduce in 7.4 but not anymore with your patch applied. Patchset 2 fixes this reported bug and also fixes empty Navigator occurrences when multiple documents are opened at once: https://gerrit.libreoffice.org/c/core/+/164607/2 Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/2d88ea62d4b6663cf8839e5484e2ae8042112f81 tdf#160093 Fix SdNavigator empty after inserting formula OLE object It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Thanks Jim! Verified the fix in a local build. OK to mark as fixed and cherrypick to 24.2 and 7.6 if straight-forward? (In reply to Stéphane Guillou (stragu) from comment #5) > OK to mark as fixed and cherrypick to 24.2 and 7.6 if straight-forward? Sorry for not marking this as fixed sooner. I think it would be OK to cherrypick to 24.2 and 7.6. |