Summary: | Crash on reload of file (segfault in libswlo.so) | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Stéphane Guillou (stragu) <stephane.guillou> |
Component: | Writer | Assignee: | Caolán McNamara <caolan.mcnamara> |
Status: | VERIFIED FIXED | ||
Severity: | critical | CC: | buzea.bogdan, caolan.mcnamara, serval2412, telesto |
Priority: | medium | Keywords: | bibisectNotNeeded, regression |
Version: | 7.3.7.2 release | ||
Hardware: | x86-64 (AMD64) | ||
OS: | All | ||
See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=159025 | ||
Whiteboard: | target:7.6.0 target:7.5.3 | ||
Crash report or crash signature: | ["SwViewShellImp::DisposeAccessible(SwFrame const*, SdrObject const*, bool, bool)","SwTableNode::DelFrames(SwRootFrame const*)","SwViewShell::GetLayout() const"] | Regression By: | |
Bug Depends on: | |||
Bug Blocks: | 133092 | ||
Attachments: |
test document
report from running under clang-asan |
Description
Stéphane Guillou (stragu)
2023-03-15 12:44:59 UTC
Created attachment 185980 [details]
report from running under clang-asan
Looks like a stale pointer
https://gerrit.libreoffice.org/c/core/+/148939 and https://gerrit.libreoffice.org/c/core/+/148940 might help Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/12233f437e6299e6dcea3ee1490a80da2bef2372 Related: tdf#154205 avoid use of destroyed ViewShell It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/67d353ff50712a036d04b1c0ffab68f2a21b5008 Related: tdf#154205 skip Invalidating content a11y relations when closing doc It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. how about with those applied, does that solve it? On pc Debian x86-64 with master sources updated today + gtk3 rendering, after 4-5 reloads, I don't reproduce the crash. Now I hadn't tested before Caolán's patches so it's just for the record. Tank you all, I just tested with a build including Caolán's patch and 20 successive reloads didn't crash it. Caolán, please go ahead and mark as fixed :) Too dangerous to cherry-pick to 7.5 in your opinion? Looking at the three associated crash signatures, it's a grand total of 15 crash reports, and I suspect a good chunk of them is me... [Automated Action] NeedInfo-To-Unconfirmed (Setting back to new after needinfo -> unconfirmed. Caolán can set to Fixed.) done in trunk, I've done backports to 7-5 in gerrit Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-5": https://git.libreoffice.org/core/commit/788e36d514260413633e03fc7c47cb390e867176 Related: tdf#154205 skip Invalidating content a11y relations when closing doc It will be available in 7.5.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-5": https://git.libreoffice.org/core/commit/bb2d1555703e6f894fa158eeef4fae4bf7ac6915 Related: tdf#154205 avoid use of destroyed ViewShell It will be available in 7.5.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |