Summary: | macOS title bar not reflecting dark mode setting | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | steve <lo> |
Component: | LibreOffice | Assignee: | Not Assigned <libreoffice-bugs> |
Status: | RESOLVED WORKSFORME | ||
Severity: | trivial | CC: | lo, sberg.fun, serval2412, sierkb, thorsten.wagner.4 |
Priority: | medium | Keywords: | bibisectNotNeeded, regression |
Version: | 6.4.2.1 rc | ||
Hardware: | All | ||
OS: | macOS (All) | ||
Whiteboard: | |||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 103184, 118017 | ||
Attachments: |
macOS title bar 6.4.1.2
macOS title bar 6.4.2.1 2020-03-11 master |
Description
steve
2020-03-11 14:36:56 UTC
Created attachment 158611 [details]
macOS title bar 6.4.1.2
Created attachment 158612 [details]
macOS title bar 6.4.2.1
Thorsten: thought you might be interested in this one. With https://cgit.freedesktop.org/libreoffice/core/commit/?id=8d11b953c0a69f4f5eb5ca42dec3812a62d0cd0f, is it fixed on master? Created attachment 158621 [details]
2020-03-11 master
Issue is not related to tdf#125532. Reason is tdf#122218: https://bugs.documentfoundation.org/show_bug.cgi?id=122218 Dark theme for UI elements is supported with macOS SDK 10.14 and higher only. Due to blurry fonts on retina displays, SDK has been withdrawn to 10.13. Furthermore there is no comprehensive dark theme implementation with SDK 10.14 too. There are only a few UI elements changed by the OS without support within LO code base (like toolbar shown by the screenshots). From this point of view, using light theme only is consistent as long as comprehensive dark theme implementation is not done. BTW: Solving the existing problems with SDK 10.14 and higher is a prerequisite for implementing dark theme in the future. (In reply to Thorsten Wagner from comment #5) > ... > BTW: Solving the existing problems with SDK 10.14 and higher is a > prerequisite for implementing dark theme in the future. Thank you for your detailed feedback. I suppose too that an even higher priority than SDK part for MacOs part is notarization (which is an almost blocker on Catalina if I well understood) (In reply to Thorsten Wagner from comment #5) > Issue is not related to tdf#125532. Reason is tdf#122218: > > https://bugs.documentfoundation.org/show_bug.cgi?id=122218 Indeed, it apparently is <https://git.libreoffice.org/core/+/645fe53be0dc36535dba0ed684e21ca4cda80d70%5E!/> "tdf#122218: Hack to avoid blurry text with macOS SDK 10.15" which prevents title bars (among other things) from adapting color to dark mode (at least when building LO against MacOSX10.15.sdk and running it on macOS 10.15.4). > Date: Thu, 30 Apr 2020 04:00:33 +0000 [...] > QA Administrators <qa-admin@libreoffice.org> changed: > > What |Removed |Added > ---------------------------------------------------------------------------- > Keywords| |bibisectRequest Why? What needs bibisecting here? Comment 7 already identified the relevant commit. Since this bug seeems to be the only remaining issue blocking Bug 118017 (macOS-Dark-Mode): is there any progress on this issue? Sierkt I assure you this is not the only bug blocking macOS dark mode. Just no one has found the time or willingness to check open existing bugs and connect them with the macOS dark mode meta bug. This is no longer a problem in Version: 7.5.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 1435c5b12646269e2b5b58ec7d51626dce6505db CPU threads: 8; OS: Mac OS X 13.0.1; UI render: default; VCL: osx Locale: de-DE (en_DE.UTF-8); UI: en-US Calc: threaded The title bar now automatically switches as expected when changing Appearance in System Settings > Appearance. |