Summary: | Lockfiles can be overridden | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Nigel Arnot <nigel.arnot> |
Component: | UI | Assignee: | Not Assigned <libreoffice-bugs> |
Status: | RESOLVED WORKSFORME | ||
Severity: | enhancement | CC: | aron.budea, cno, heiko.tietze, nigel.arnot, samuel.mehrbrodt, thb, thomas.lendo, xiscofauli |
Priority: | medium | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=108210 https://bugs.documentfoundation.org/show_bug.cgi?id=157943 |
||
Whiteboard: | |||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 114300 | ||
Attachments: | Locked dialog |
Description
Nigel Arnot
2018-10-23 11:20:30 UTC
Reproduced in Version: 6.3.0.0.alpha0+ Build ID: 392729c735bb82eecf29bae5527ec786ca293f34 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: Let UX have a look if wording can be improved. Created attachment 149381 [details]
Locked dialog
Maybe just show "Open read-only" and "Cancel" buttons by default. Then have a checkbox "I want to override the lockfile" which changes the "Open read-only" button to an "Open" button. Overriding the lock file should be done only when the previous process has not ended gracefully, right? Don't think we want to take over the work from other users- in this case we open readonly or as a copy. Open readonly in local mode shows an infobar where the user can enable the edit mode. When opened as a copy (aka inserted from file) it shows the save dialog on ordinary save actions. Sounds like the usual way for me. Rather than renaming a message that nobody care about we should tweak the workflow. The (technical) question remains how to deal with the lockfile from a terminated process. Can you evaluate this status safely anyway? (In reply to Heiko Tietze from comment #5) > Overriding the lock file should be done only when the previous process has > not ended gracefully, right? Don't think we want to take over the work from > other users- in this case we open readonly or as a copy. No, please read comment 0, especially: > When a Libreoffice document is open by a user A on a shared folder and user B tries to open it, he receives a warning that the file is in use. However, it also says something like "Alternatively, you can ignore the lock file and open the document anyway". It can also happen that the lockfile from another user doesn't get cleaned up, so removing the option to open the file (despite locked by another user) is no option. from the UX-meeting 2019-03-05: Dialog + message needs to be discussed + "Opening editable potentially ends up in data loss when more users access the same file." + checkbox "[ ] Open editable anyway" + buttons [Open] [Cancel] (no "Open read only") Opinions? (In reply to Cor Nouws from comment #8) I don't think this is an improvement for the end user. As there is the infobar when opening read-only, the user is informed. Is the current situation a problem, that is discussed in ask.libreoffice or elsewhere? There is no infobar yet, but it would be consistent. If that's not possible without too much effort the proposal from comment 8 is fine. The dialog has been reworked since this bug was opened and looks much better nowadays. Also, there is the option /org.openoffice.Office.Common/Misc/AllowOverrideLocking which can be used to disable the "Open" button. So I'd say this bug is sufficiently fixed. |