Summary: | FILESAVE XLS Excessive number of rows or columns warning when saving after selecting all | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | ady <adylo811517> |
Component: | Calc | Assignee: | Not Assigned <libreoffice-bugs> |
Status: | NEW --- | ||
Severity: | normal | CC: | buzea.bogdan, ilmari.lauhakangas, telesto |
Priority: | medium | Keywords: | bibisected, filter:xls, implementationError |
Version: | 4.3.0.4 release | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=92164 https://bugs.documentfoundation.org/show_bug.cgi?id=50471 |
||
Whiteboard: | |||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 88174 |
Description
ady
2023-04-25 10:43:37 UTC
Yes, selection only gives the warning but should consider whether cells contain any data. Not sure if this topic is covered in the see also or other tickets. (In reply to Heiko Tietze from comment #1) > Yes, selection only gives the warning but should consider whether cells > contain any data. Not only data contained within a cell, but any kind of valid dependency (e.g. conditional format depending on some other cell, Validity, etc.). All that, except if the only thing is selection of the cell. Selection by itself (without any "real" dependency) should not trigger a warning, because there is no real loss (of any kind of data) when saving. Apparently, the selected area is being "saved", so when cells above the limit of XLS format are selected, the warnings are triggered (either rows or columns, depending on which area was selected). > Not sure if this topic is covered in the see also or other > tickets. Other reports have contradicting comments and apparently some behavior has been tracked to older versions (which I doubt, but OK). This has a simple STR for both warnings. See bug 92164 comment 38 and up. Bibisected the behaviour change with linux-43max to 28e9efe5b4d6699b33498953e798f76008edaeda fdo#40694 - Error in message when truncating col/row numbers in calc It looks like while older version (3.5.x) gives a wrong warning The newer version doesn't give any warnings. With this it gives the warning with correct message. > fdo#40694 - Error in message when truncating col/row numbers in calc
>
> It looks like while older version (3.5.x) gives a wrong warning
> The newer version doesn't give any warnings.
> With this it gives the warning with correct message.
In LO 4.2, there was no warning when some data would had been lost while saving as XLS (i.e. beyond cell IV65536).
In LO 4.3, the warning indeed exists.
The problem is that, even with no relevant/real dependency beyond cell IV65536, by just selecting (for instance) an entire row/column while saving as XLS, the warning is shown even if there is no real data loss. In such cases, the warning is misleading.
Is the "selected area(s)" even really "saved" somewhere in the XLS file?
If there is no real data loss, the warning should not be shown.
(In reply to ady from comment #5) > > fdo#40694 - Error in message when truncating col/row numbers in calc > > > > It looks like while older version (3.5.x) gives a wrong warning > > The newer version doesn't give any warnings. > > With this it gives the warning with correct message. > > In LO 4.2, there was no warning when some data would had been lost while > saving as XLS (i.e. beyond cell IV65536). > > In LO 4.3, the warning indeed exists. > > The problem is that, even with no relevant/real dependency beyond cell > IV65536, by just selecting (for instance) an entire row/column while saving > as XLS, the warning is shown even if there is no real data loss. In such > cases, the warning is misleading. > > Is the "selected area(s)" even really "saved" somewhere in the XLS file? > > If there is no real data loss, the warning should not be shown. Maybe I should have added that that was me quoting the commit message. To sum up... Each of the possible messages (depending on the specific "selected area") are: " The document contains more columns than supported in the selected format. Additional columns were not saved. " " The document contains more rows than supported in the selected format. Additional rows were not saved. " The messages themselves are not the real problem. The problem is that the "selected" area should not really be part of the active area – or however the actually-relevant area is supposed to be named – to be (checked for limits in XLS format and) saved. I guess the problem is in: sc/source/filter/excel/xehelper.cxx |