Bug 147388

Summary: Cell cursor should take cell border width into account
Product: LibreOffice Reporter: Mike Kaganski <mikekaganski>
Component: CalcAssignee: Not Assigned <libreoffice-bugs>
Status: RESOLVED WONTFIX    
Severity: enhancement CC: buzea.bogdan, heiko.tietze, libreoffice-ux-advise, lo, stephane.guillou
Priority: medium Keywords: needsUXEval
Version: Inherited From OOo   
Hardware: All   
OS: All   
See Also: https://bugs.documentfoundation.org/show_bug.cgi?id=142121
https://bugs.documentfoundation.org/show_bug.cgi?id=145080
https://bugs.documentfoundation.org/show_bug.cgi?id=108240
Whiteboard:
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 59284, 109139    
Attachments: Screenshot of 400%-scaled thin border with cursor
Numbers (macOS)

Description Mike Kaganski 2022-02-12 08:36:43 UTC
Created attachment 178237 [details]
Screenshot of 400%-scaled thin border with cursor

When scaling spreadsheet, the cursor visibility becomes poor on bordered cells, because it has a fixed width, which soon becomes smaller than width of the border.

See the screenshot of such a case.

The cursor line width should be no smaller (possibly better a bit wider) than the visible size of the border.
Comment 1 LeroyG 2022-02-13 16:40:00 UTC
Why not playing with a contrasting color?
Comment 2 steve 2022-02-14 09:57:45 UTC
@LeroyG contrast of highlight color is discussed here: https://bugs.documentfoundation.org/show_bug.cgi?id=145080 and will likely be fixed when macOS target is raised to macOS 10.14 Mojave since then Highlight Color will be correctly differentiated from System Accent Color.
Comment 3 steve 2022-02-14 10:01:26 UTC
My comment is only about macOS situation and slightly off-topic, sorry.

This bug is valid as per screenshot, so setting to new.

(wish we had an edit function in bugzilla)
Comment 4 Stéphane Guillou (stragu) 2023-07-10 09:47:57 UTC
Mike, isn't this fixed in 7.4 with Heiko's c32994e22ff291b0227ed74de6d0d050cf0901c8 for bug 143733 ?
It works well with the default border thickness of 0.75 points.

Or do you want it to adapt to any border thickness?
Comment 5 Mike Kaganski 2023-07-10 09:53:00 UTC
(In reply to Stéphane Guillou (stragu) from comment #4)

It wouldn't fix it, only make less problematic - because it would only be problem on wider borders.

> Or do you want it to adapt to any border thickness?

Of course.
Comment 6 Stéphane Guillou (stragu) 2023-07-10 15:29:02 UTC
Thanks Mike.

Bug 108240 contradicts what is requested here: it wants to never hide the border of the active cell.

UX team, what do you think is the best solution here?

(Anyone who tests, please use a recent master build as there has been various changes in that area between 7.4 and 7.6)
Comment 7 Mike Kaganski 2023-07-10 16:40:20 UTC
(In reply to Stéphane Guillou (stragu) from comment #6)

Then ignore this, because the improvement mentioned in comment 4 is substantial, and possibly the rest is just nitpicking.
Comment 8 Heiko Tietze 2023-07-11 09:57:09 UTC
Created attachment 188308 [details]
Numbers (macOS)

The only chance we have is to follow the example of Numbers. Is it needed, or resolve WF?
Comment 9 Mike Kaganski 2023-07-11 10:26:52 UTC
Let's WF :)