Summary: | Use same border preset tooltips between toolbar and sidebar | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Stéphane Guillou (stragu) <stephane.guillou> |
Component: | Calc | Assignee: | Not Assigned <libreoffice-bugs> |
Status: | NEW --- | ||
Severity: | normal | CC: | heiko.tietze, mentoring, rafael.palma.lima |
Priority: | medium | Keywords: | difficultyBeginner, easyHack, skillCpp, topicUI |
Version: | 7.2.4.1 release | ||
Hardware: | x86-64 (AMD64) | ||
OS: | Linux (All) | ||
See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=146466 https://bugs.documentfoundation.org/show_bug.cgi?id=141774 |
||
Whiteboard: | reviewed:2022 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 103428, 113654 | ||
Attachments: | Overview of options between toolbar, sidebar and dialog (LO 7.3) |
Description
Stéphane Guillou (stragu)
2021-12-29 10:48:11 UTC
Created attachment 177189 [details]
Overview of options between toolbar, sidebar and dialog (LO 7.3)
This spreadsheet shows the differences between toolbar, sidebar and cell format dialog.
The cells sharing a background colour are the ones that currently have different tooltips when they should probably have the same one.
I support this request. As a user, I also find it weird to have so many differences between the toolbar and the sidebar. Let's add the UX team in the loop. The toolbar button uses include/svx/strings.hrc starting with #define RID_SVXSTR_TABLE_PRESET_NONE while the sidebar is defined in a ui file with tooltips for each item. I suggest to assign the RID_SVXSTR* tooltips per code like sc/source/ui/sidebar/CellBorderStyleControl.cxx #include <svx/strings.hrc> #include <svx/dialmgr.hxx> void CellBorderStylePopup::Initialize() { mxTBBorder1->connect_clicked ( LINK(this, CellBorderStylePopup, TB1SelectHdl) ); mxTBBorder1->set_item_tooltip_text(0, SvxResId(RID_SVXSTR_TABLE_PRESET_NONE)); mxTBBorder1->set_item_tooltip_text(1, SvxResId( ... Perhaps it makes sense to clean up tooltip from the ui file to remove confusion. I would like to look into this. One doubt, till what index, do we need to assign the RID_SVXSTR to the code line? Like you have started from (0,...) then '(1,....)', so till which index we need to assign this? Thanks :) (In reply to Radhey Parekh from comment #4) > ...till what index, do we need to assign the RID_SVXSTR to the code line? Why not use all 20? I guess the presets are more than 20 , because when we select 2 adjecent cells, the presets are different which are not included in the excel sheet |